Skip to content

fix(attempt): attempt to fix flashy splashscreen #12460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gkartalis wants to merge 1 commit into from
Closed

fix(attempt): attempt to fix flashy splashscreen #12460

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 2 additions & 12 deletions ios/Artsy/Networking/API_Modules/ArtsyAPI+DeviceTokens.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,23 +10,17 @@ @implementation ArtsyAPI (DeviceTokens)
+ (AFHTTPRequestOperation *)setAPNTokenForCurrentDevice:(NSString *)token success:(void (^)(id response))success failure:(void (^)(NSError *error))failure
{
NSString *name = [[UIDevice currentDevice] name];

if (token && name) {
NSURLRequest *request = [ARRouter newSetDeviceAPNTokenRequest:token forDevice:name];

// TODO: Is it a problem that this can be nil?
// Should we fail loudly? Wait for the httpClient to be ready?
if (!request) {
return nil;
}

return [ArtsyAPI performRequest:request success:success failure:^(NSURLRequest *request, NSHTTPURLResponse *response, NSError *error) {
if (failure) {
failure(error);
}
}];
}

return nil;
}

Expand All @@ -39,10 +33,6 @@ + (AFHTTPRequestOperation *)deleteAPNTokenForCurrentDeviceWithCompletion:(void (
}
NSURLRequest *request = [ARRouter newDeleteDeviceRequest:token];

if (!request) {
completion();
return nil;
}
return [ArtsyAPI performRequest:request success:^ (id _) {
completion();
} failure:^(NSURLRequest *request, NSHTTPURLResponse *response, NSError *error) {
Expand Down