feat: enable new architecture

.circleci/config.yml

@@ -491,6 +491,9 @@ jobs:
       - store_artifacts:
           path: android/app/build/reports
 
+      - store_artifacts:
+          path: .gradle/daemon/
+
       - save_cache:
           key: << pipeline.parameters.android_native_cache_key >>
           paths:
@@ -518,7 +521,7 @@ parameters:
   # Update Manually these versions below in order to hard overwrite the caches
   node_modules_cache_key:
     type: string
-    default: v28-node_modules-{{ checksum ".manifests/node_modules" }}
+    default: v29-node_modules-{{ checksum ".manifests/node_modules" }}
   gems_cache_key:
     type: string
     default: v13-gems-{{ checksum "Gemfile.lock" }}-{{ arch }}
@@ -530,14 +533,14 @@ parameters:
     default: v30-app_build_ios-{{ checksum ".manifests/app_build" }}
   app_build_android_cache_key:
     type: string
-    default: v15-app_build_android-{{ checksum "../workspace/.manifests/app_build" }}
+    default: v16-app_build_android-{{ checksum "../workspace/.manifests/app_build" }}
   ios_native_code_cache_prefix:
     type: string
     # this one is not including the checksum due to path differences in the checksum
     default: v19-test-success
   android_native_cache_key:
     type: string
-    default: v18-test-success-{{ checksum "../workspace/.manifests/android_native" }}
+    default: v19-test-success-{{ checksum "../workspace/.manifests/android_native" }}
 
 workflows:
   nightly:

.github/workflows/android-e2e-maestro.yml

@@ -65,14 +65,25 @@ jobs:
       - name: Add Maestro to PATH
         run: echo "$HOME/.maestro/bin" >> $GITHUB_PATH
 
+      - name: Free Disk Space
+        uses: jlumbroso/free-disk-space@54081f138730dfa15788a46383842cd2f914a1be
+        with:
+          tool-cache: false
+          android: false
+          dotnet: true
+          haskell: true
+          large-packages: true
+          docker-images: true
+          swap-storage: true
+
       - name: Run tests with Android emulator
         uses: reactivecircus/android-emulator-runner@v2
         with:
           api-level: 34
           arch: x86_64
           ram-size: "8192M"
           heap-size: "4096M"
-          disk-size: "10G"
+          disk-size: "8G"
           cores: 4
           disable-animations: false
           disable-spellchecker: true

.github/workflows/build-maestro-android.yml

@@ -9,7 +9,7 @@ jobs:
   build-android-qa:
     if: github.ref == 'refs/heads/main'
     runs-on: ubuntu-latest
-    timeout-minutes: 60
+    timeout-minutes: 90
 
     steps:
       - name: Checkout repository
@@ -57,9 +57,9 @@ jobs:
         uses: actions/cache@v4
         with:
           path: .yarn/cache
-          key: yarn-v4-${{ runner.os }}-${{ hashFiles('yarn.lock') }}
+          key: yarn-v5-${{ runner.os }}-${{ hashFiles('yarn.lock') }}
           restore-keys: |
-            yarn-v4-${{ runner.os }}-
+            yarn-v5-${{ runner.os }}-
 
       - name: Install Node.js dependencies
         run: yarn install --immutable
@@ -71,9 +71,9 @@ jobs:
             ~/.gradle/caches
             ~/.gradle/wrapper
             android/.gradle
-          key: gradle-v2-${{ runner.os }}-${{ hashFiles('**/*.gradle*', '**/gradle-wrapper.properties') }}
+          key: gradle-v3-${{ runner.os }}-${{ hashFiles('**/*.gradle*', '**/gradle-wrapper.properties') }}
           restore-keys: |
-            gradle-v2-${{ runner.os }}-
+            gradle-v3-${{ runner.os }}-
 
       - name: Download fonts from s3
         run: ./scripts/setup/download-fonts

.github/workflows/build-maestro-ios.yml

@@ -9,7 +9,7 @@ jobs:
   build-ios-qa:
     if: github.ref == 'refs/heads/main'
     runs-on: macos-15
-    timeout-minutes: 90
+    timeout-minutes: 120
 
     steps:
       - name: Checkout repository
@@ -48,9 +48,9 @@ jobs:
         uses: actions/cache@v4
         with:
           path: .yarn/cache
-          key: yarn-v4-${{ runner.os }}-${{ hashFiles('yarn.lock') }}
+          key: yarn-v5-${{ runner.os }}-${{ hashFiles('yarn.lock') }}
           restore-keys: |
-            yarn-v4-${{ runner.os }}-
+            yarn-v5-${{ runner.os }}-
 
       - name: Install Node.js dependencies
         run: yarn install --immutable
@@ -62,9 +62,9 @@ jobs:
           path: |
             ios/Pods
             ~/Library/Caches/CocoaPods
-          key: pods-v2-${{ runner.os }}-${{ hashFiles('**/Podfile.lock') }}
+          key: pods-v3-${{ runner.os }}-${{ hashFiles('**/Podfile.lock') }}
           restore-keys: |
-            pods-v2-${{ runner.os }}-
+            pods-v3-${{ runner.os }}-
 
       - name: Download fonts from s3
         run: ./scripts/setup/download-fonts

EXAMPLES.md

@@ -114,5 +114,3 @@ Links:
 
 - [OnboardingWelcome.tsx](src/app/Scenes/Onboarding/OnboardingWelcome.tsx)
 - [Search.tsx](src/app/Scenes/Search/Search.tsx)
-- [AnimatableHeaderLargeTitle.tsx](src/app/Components/AnimatableHeader/AnimatableHeaderLargeTitle.tsx)
-- [AnimatableHeader.tsx](src/app/Components/AnimatableHeader/AnimatableHeader.tsx)

HACKS.md

@@ -283,3 +283,28 @@ not reset. This causes the module to never start listening again causing events
 #### When can we remove this:
 
 It can be removed once if we stop using the singleton pattern or get rid of ARNotificationsManagerModule, or it is fixed upstream.
+
+## react-native-reanimated package.json flags and react-native patch
+
+### USE_COMMIT_HOOK_ONLY_FOR_REACT_COMMITS
+
+#### Explanation/Context:
+
+This feature flag was added to fix performance issues with scrolling. See https://docs.swmansion.com/react-native-reanimated/docs/guides/performance/#%EF%B8%8F-lower-fps-while-scrolling
+
+We also added a patch to react-native to support this flag and temporarily enabled preventShadowTreeCommitExhaustion and enableCppPropsIteratorSetter flags to fix performance issues.
+
+#### When can we remove this:
+
+When reanimated adopts this by default.
+
+## react-native-webview passing constant for decelerationRate prop
+
+#### Explanation/Context:
+
+This is a bug on the new architecture on Android with this prop and react-native-webview.
+
+#### When can we remove this:
+
+When this is merged and we update react-native-webview to a version that contains it:
+https://github.com/react-native-webview/react-native-webview/pull/3885

android/gradle.properties

@@ -43,11 +43,12 @@ reactNativeArchitectures=armeabi-v7a,arm64-v8a,x86,x86_64
 # your application. You should enable this flag either if you want
 # to write custom TurboModules/Fabric components OR use libraries that
 # are providing them.
-newArchEnabled=false
+newArchEnabled=true
 
 # Use this property to enable or disable the Hermes JS engine.
 # If set to false, you will be using JSC instead.
 hermesEnabled=true
 
 # Specify dotenv file name for access in build.gradle
-dotenv.filename=../.env.shared
+dotenv.filename=../.env.shared
+

docs/best_practices.md

@@ -225,7 +225,6 @@ const App = () => {
   return (
    <FlashList
     renderItem={renderItem}
-    estimatedItemSize={ESTIMATED_ITEM_SIZE}
     keyExtractor={keyExtractor}
   >
   )

e2e/README.md

@@ -6,9 +6,19 @@ It is used like other tools such as Cypress, Appium, and Detox in order to run t
 ## Steps to run
 
 1. install maestro by following the instructions [here](https://maestro.mobile.dev/getting-started/installing-maestro)
-   - `curl -Ls "https://get.maestro.mobile.dev" | bash`
-   - `brew tap facebook/fb`
-   - `brew install facebook/fb/idb-companion`
+
+   - Using Curl
+
+   ```bash
+      curl -Ls "https://get.maestro.mobile.dev" | bash
+   ```
+
+   - Using Homebrew
+
+   ```bash
+    brew tap facebook/fb
+    brew install facebook/fb/idb-companion
+   ```
 
 ### iOS
 

e2e/perf/run-perf-tests.sh

@@ -16,8 +16,9 @@ timestamp=$(date +"%Y-%m-%d_%H:%M:%S")
 # Note that this is only supported on android devices or emulators at the moment.
 flashlight test --bundleId net.artsy.app \
   --testCommand "maestro test e2e/perf/perf-test-home.yml" \
+  --beforeEachCommand "adb shell am force-stop net.artsy.app" \
   --duration 10000 \
-  --iterationCount 1 \
+  --iterationCount 3 \
   --skipRestart \
   --record \
   --resultsFilePath "flashlight_results_$timestamp.json" \

ios/Artsy.xcodeproj/project.pbxproj

@@ -14,7 +14,7 @@
 		1A4B97C1283CDD5A00878EAE /* ARTemporaryAPIModule.m in Sources */ = {isa = PBXBuildFile; fileRef = 1A4B979D283CDD5900878EAE /* ARTemporaryAPIModule.m */; };
 		1A4B97C3283CDD5A00878EAE /* ARMediaPreviewController.m in Sources */ = {isa = PBXBuildFile; fileRef = 1A4B97A1283CDD5900878EAE /* ARMediaPreviewController.m */; };
 		1A4B97C6283CDD5A00878EAE /* ARComponentViewController.m in Sources */ = {isa = PBXBuildFile; fileRef = 1A4B97A9283CDD5900878EAE /* ARComponentViewController.m */; };
-		1A4B97C8283CDD5A00878EAE /* ARPHPhotoPickerModule.m in Sources */ = {isa = PBXBuildFile; fileRef = 1A4B97AF283CDD5900878EAE /* ARPHPhotoPickerModule.m */; };
+		1A4B97C8283CDD5A00878EAE /* ARPHPhotoPickerModule.mm in Sources */ = {isa = PBXBuildFile; fileRef = 1A4B97AF283CDD5900878EAE /* ARPHPhotoPickerModule.mm */; };
 		1A4B97C9283CDD5A00878EAE /* ARNotificationsManager.m in Sources */ = {isa = PBXBuildFile; fileRef = 1A4B97B0283CDD5900878EAE /* ARNotificationsManager.m */; };
 		1A4E5119283F91BA0008EF35 /* Artsy+UILabels.m in Sources */ = {isa = PBXBuildFile; fileRef = 1A4E50FB283F91B90008EF35 /* Artsy+UILabels.m */; };
 		1A4E511A283F91BA0008EF35 /* UIView+ARDrawing.m in Sources */ = {isa = PBXBuildFile; fileRef = 1A4E50FC283F91B90008EF35 /* UIView+ARDrawing.m */; };
@@ -216,7 +216,7 @@
 		CB762B3E2911A5E100881194 /* ar_vir_opening_frame.jpg in Resources */ = {isa = PBXBuildFile; fileRef = CB762B362911A5E100881194 /* ar_vir_opening_frame.jpg */; };
 		CBA500F32C654F8400DDBCC0 /* AppDelegate+DeeplinkTimeout.m in Sources */ = {isa = PBXBuildFile; fileRef = CBA500F22C654F8400DDBCC0 /* AppDelegate+DeeplinkTimeout.m */; };
 		CBA500F62C6553FF00DDBCC0 /* ARTDeeplinkTimeoutModule.m in Sources */ = {isa = PBXBuildFile; fileRef = CBA500F52C6553FF00DDBCC0 /* ARTDeeplinkTimeoutModule.m */; };
-		CBC1F3F12E68CF11008CCF48 /* ARAppDelegateHelper.m in Sources */ = {isa = PBXBuildFile; fileRef = CBC1F3F02E68CF11008CCF48 /* ARAppDelegateHelper.m */; };
+		CBC1F3F12E68CF11008CCF48 /* ARAppDelegateHelper.mm in Sources */ = {isa = PBXBuildFile; fileRef = CBC1F3F02E68CF11008CCF48 /* ARAppDelegateHelper.mm */; };
 		CBC1F3F42E68D0D7008CCF48 /* ARWindow.m in Sources */ = {isa = PBXBuildFile; fileRef = CBC1F3F32E68D0D4008CCF48 /* ARWindow.m */; };
 		CBD794D72BBB5622003B3CB5 /* StarscreamExtensions.swift in Sources */ = {isa = PBXBuildFile; fileRef = CBD794D62BBB5622003B3CB5 /* StarscreamExtensions.swift */; };
 		CBD794DB2BBC40A4003B3CB5 /* PrivacyInfo.xcprivacy in Resources */ = {isa = PBXBuildFile; fileRef = CBD794DA2BBC40A4003B3CB5 /* PrivacyInfo.xcprivacy */; };
@@ -555,7 +555,7 @@
 		1A4B97A9283CDD5900878EAE /* ARComponentViewController.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = ARComponentViewController.m; sourceTree = "<group>"; };
 		1A4B97AC283CDD5900878EAE /* ARPHPhotoPickerModule.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = ARPHPhotoPickerModule.h; sourceTree = "<group>"; };
 		1A4B97AD283CDD5900878EAE /* ARNotificationsManager.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = ARNotificationsManager.h; sourceTree = "<group>"; };
-		1A4B97AF283CDD5900878EAE /* ARPHPhotoPickerModule.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = ARPHPhotoPickerModule.m; sourceTree = "<group>"; };
+		1A4B97AF283CDD5900878EAE /* ARPHPhotoPickerModule.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = ARPHPhotoPickerModule.mm; sourceTree = "<group>"; };
 		1A4B97B0283CDD5900878EAE /* ARNotificationsManager.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = ARNotificationsManager.m; sourceTree = "<group>"; };
 		1A4E50FB283F91B90008EF35 /* Artsy+UILabels.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = "Artsy+UILabels.m"; sourceTree = "<group>"; };
 		1A4E50FC283F91B90008EF35 /* UIView+ARDrawing.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = "UIView+ARDrawing.m"; sourceTree = "<group>"; };
@@ -916,7 +916,7 @@
 		CBA500F52C6553FF00DDBCC0 /* ARTDeeplinkTimeoutModule.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = ARTDeeplinkTimeoutModule.m; sourceTree = "<group>"; };
 		CBA7CF22282BF6310025AEA5 /* Artsy_Tests-Info.plist */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.plist.xml; path = "Artsy_Tests-Info.plist"; sourceTree = "<group>"; };
 		CBC1F3EF2E68CF11008CCF48 /* ARAppDelegateHelper.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = ARAppDelegateHelper.h; sourceTree = "<group>"; };
-		CBC1F3F02E68CF11008CCF48 /* ARAppDelegateHelper.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = ARAppDelegateHelper.m; sourceTree = "<group>"; };
+		CBC1F3F02E68CF11008CCF48 /* ARAppDelegateHelper.mm */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.objcpp; path = ARAppDelegateHelper.mm; sourceTree = "<group>"; };
 		CBC1F3F22E68D0CC008CCF48 /* ARWindow.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = ARWindow.h; sourceTree = "<group>"; };
 		CBC1F3F32E68D0D4008CCF48 /* ARWindow.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = ARWindow.m; sourceTree = "<group>"; };
 		CBD794D62BBB5622003B3CB5 /* StarscreamExtensions.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = StarscreamExtensions.swift; sourceTree = "<group>"; };
@@ -1429,7 +1429,7 @@
 			children = (
 				1A4B97AC283CDD5900878EAE /* ARPHPhotoPickerModule.h */,
 				1A4B97AD283CDD5900878EAE /* ARNotificationsManager.h */,
-				1A4B97AF283CDD5900878EAE /* ARPHPhotoPickerModule.m */,
+				1A4B97AF283CDD5900878EAE /* ARPHPhotoPickerModule.mm */,
 				1A4B97B0283CDD5900878EAE /* ARNotificationsManager.m */,
 			);
 			path = EigenCommunications;
@@ -2543,7 +2543,7 @@
 				CBC1F3F22E68D0CC008CCF48 /* ARWindow.h */,
 				CBC1F3F32E68D0D4008CCF48 /* ARWindow.m */,
 				CBC1F3EF2E68CF11008CCF48 /* ARAppDelegateHelper.h */,
-				CBC1F3F02E68CF11008CCF48 /* ARAppDelegateHelper.m */,
+				CBC1F3F02E68CF11008CCF48 /* ARAppDelegateHelper.mm */,
 				CB2033332E56593700A06281 /* main.swift */,
 				CB51280D2DB2EBCE00C6A884 /* AppDelegateCategories */,
 				CBE3249927E275A100395A93 /* ARTArtsyNativeModule.h */,
@@ -3892,7 +3892,7 @@
 				CBD794D72BBB5622003B3CB5 /* StarscreamExtensions.swift in Sources */,
 				CBE326AF27E275A300395A93 /* LiveAuctionLoadingView.swift in Sources */,
 				CBE326E127E275A300395A93 /* ARFileUtils.m in Sources */,
-				1A4B97C8283CDD5A00878EAE /* ARPHPhotoPickerModule.m in Sources */,
+				1A4B97C8283CDD5A00878EAE /* ARPHPhotoPickerModule.mm in Sources */,
 				CBE3269727E275A300395A93 /* AppDelegate+ShortcutItems.m in Sources */,
 				CBE326E627E275A300395A93 /* UIApplicationStateEnum.m in Sources */,
 				CBE3270E27E275A300395A93 /* AuctionTitleView.swift in Sources */,
@@ -3944,7 +3944,7 @@
 				CBE3267727E275A300395A93 /* UIImageView+AsyncImageLoading.m in Sources */,
 				CB18284829DF3F75006A0805 /* Utilities.swift in Sources */,
 				CBE3271D27E275A300395A93 /* ARNotificationView.m in Sources */,
-				CBC1F3F12E68CF11008CCF48 /* ARAppDelegateHelper.m in Sources */,
+				CBC1F3F12E68CF11008CCF48 /* ARAppDelegateHelper.mm in Sources */,
 				CBE3276C27E275A400395A93 /* MTLModel+Dictionary.m in Sources */,
 				CBE326E427E275A300395A93 /* ARNetworkErrorManager.m in Sources */,
 				CBE326A027E275A300395A93 /* ARUserActivity.m in Sources */,

ios/Artsy/App/ARAppDelegateHelper.m → ios/Artsy/App/ARAppDelegateHelper.mm

@@ -10,12 +10,19 @@
 #import "ARUserManager.h"
 #import "Keys.h"
 #import "ARAppStatus.h"
-#import <FBSDKCoreKit/FBSDKCoreKit-Swift.h>
+
+
+#import <AuthenticationServices/AuthenticationServices.h>
+#import <SafariServices/SafariServices.h>
+#import <FBSDKCoreKit/FBSDKCoreKit-swift.h>
+
+
 #import <Firebase.h>
 #import "BrazeReactBridge.h"
 #import "BrazeReactUtils.h"
 #import <BrazeUI/BrazeUI-Swift.h>
 
+
 @interface ARAppDelegateHelper ()
 @property (strong, nonatomic, readwrite) NSString *referralURLRepresentation;
 @property (strong, nonatomic, readwrite) NSString *landingURLRepresentation;

ios/Artsy/App/AppDelegateCategories/AppDelegate+DeeplinkTimeout.m

@@ -1,5 +1,5 @@
 #import "AppDelegate+DeeplinkTimeout.h"
-#import <Sentry/Sentry.h>
+@import Sentry;
 
 @implementation ARAppDelegateHelper (DeeplinkTimeout)
 

ios/Artsy/App_Resources/Info.plist

@@ -114,6 +114,8 @@
 	</array>
 	<key>LSRequiresIPhoneOS</key>
 	<true/>
+	<key>UIDesignRequiresCompatibility</key>
+	<true />
 	<key>LSSupportsOpeningDocumentsInPlace</key>
 	<true/>
 	<key>MGLGlyphsRasterizationMode</key>
@@ -144,7 +146,7 @@
 	<key>NSPhotoLibraryUsageDescription</key>
 	<string>Photos will be used to gauge the quality of the work you are submitting.</string>
 	<key>RCTNewArchEnabled</key>
-	<false/>
+	<true/>
 	<key>UIAppFonts</key>
 	<array>
 		<string>Unica77LL-Italic.otf</string>

ios/Artsy/View_Controllers/Util/Errors/ARNetworkErrorManager.m

@@ -3,7 +3,7 @@
 #import "ARTNativeScreenPresenterModule.h"
 
 #import <FLKAutoLayout/UIView+FLKAutoLayout.h>
-#import <Sentry/Sentry.h>
+@import Sentry;
 
 @interface ARNetworkErrorManager ()
 @property (nonatomic, strong) UILabel *activeModalView;

ios/Artsy/View_Controllers/Util/Errors/ARSentryReporter.m

@@ -1,5 +1,5 @@
 #import "ARSentryReporter.h"
-#import <Sentry/Sentry.h>
+@import Sentry;
 
 @implementation ARSentryReporter
 

ios/ArtsyStickers/Info.plist

@@ -14,6 +14,6 @@
 		<string>StickerBrowserViewController</string>
 	</dict>
 	<key>RCTNewArchEnabled</key>
-	<false/>
+	<true/>
 </dict>
 </plist>

ios/ArtsyWidget/Info.plist

@@ -12,6 +12,6 @@
 		<string>com.apple.widgetkit-extension</string>
 	</dict>
 	<key>RCTNewArchEnabled</key>
-	<false/>
+	<true/>
 </dict>
 </plist>

ios/BrazePushServiceExtension/Info.plist

@@ -14,6 +14,6 @@
 		<string>$(PRODUCT_MODULE_NAME).NotificationService</string>
 	</dict>
 	<key>RCTNewArchEnabled</key>
-	<false/>
+	<true/>
 </dict>
 </plist>

ios/Podfile

@@ -98,7 +98,7 @@ target 'Artsy' do
     :production => ENV['CIRCLE_BUILD_NUM'],
     # An absolute path to your application root.
     :app_path => "#{Pod::Config.instance.installation_root}/..",
-    new_arch_enabled: false
+    new_arch_enabled: true
   )
 
   # Networking