Skip to content

chore: add auth screen tracking #trivial #13069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
artsy-peril merged 5 commits into from
Dec 5, 2025
+13 −8
Merged

chore: add auth screen tracking #trivial #13069

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1928e1e
add authModal screen tracking - untested
brainbicycle Dec 4, 2025
3912b8b
useEffect approach to avoid render issues
brainbicycle Dec 5, 2025
442051b
use string from cohesion
brainbicycle Dec 5, 2025
a735a8f
update cohesion to fix types
brainbicycle Dec 5, 2025
55c14e0
Merge remote-tracking branch 'origin/main' into brian/auth-screen-tra…
brainbicycle Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@
"form-data": "fixed to specific versions to resolve security vulnerabilities - remove resolutions when we are away from 3.0.x and 4.0.x"
},
"dependencies": {
"@artsy/cohesion": "4.328.0",
"@artsy/cohesion": "4.330.0",
"@artsy/icons": "3.62.0",
"@artsy/palette-mobile": "22.1.0",
"@artsy/to-title-case": "1.2.0",
Expand Down
2 changes: 1 addition & 1 deletion src/app/Scenes/Onboarding/Screens/Auth/components/AuthModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ export const AuthModal: React.FC<React.PropsWithChildren> = ({ children }) => {

useEffect(() => {
tracking.authImpression()
tracking.authModalScreenView()
Copy link
Contributor Author

@brainbicycle brainbicycle Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrapping with cohesion provider oddly seemed to affect performance, since we already have this just added it here.

}, [])

const screenHeight = Dimensions.get("window").height
Expand Down Expand Up @@ -78,6 +79,5 @@ export const AuthModal: React.FC<React.PropsWithChildren> = ({ children }) => {
</Flex>
</MotiView>
</Box>
// </KeyboardAvoidingView>
Copy link
Member

@MounirDhahri MounirDhahri Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

Copy link
Contributor Author

@brainbicycle brainbicycle Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a commented out component i removed

)
}
7 changes: 6 additions & 1 deletion src/app/Scenes/Onboarding/Screens/Auth/hooks/useOnboardingAuthTracking.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { ActionType, AuthImpression } from "@artsy/cohesion"
import { ActionType, AuthImpression, OwnerType } from "@artsy/cohesion"
import { screen } from "app/utils/track/helpers"
import { useTracking } from "react-tracking"

export const useOnboardingAuthTracking = () => {
Expand All @@ -13,5 +14,9 @@ export const useOnboardingAuthTracking = () => {

trackEvent(payload)
},
authModalScreenView: () => {
const payload = screen({ context_screen_owner_type: OwnerType.authModal })
trackEvent(payload)
},
}
}
10 changes: 5 additions & 5 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,12 +27,12 @@ __metadata:
languageName: node
linkType: hard

"@artsy/cohesion@npm:4.328.0":
version: 4.328.0
resolution: "@artsy/cohesion@npm:4.328.0"
"@artsy/cohesion@npm:4.330.0":
version: 4.330.0
resolution: "@artsy/cohesion@npm:4.330.0"
dependencies:
core-js: "npm:3"
checksum: 10c0/1e8a827c878029fbc486f1c9c414c0a86d9fefff6daca78b66262fd0615e008a80abf02c69c1789ffdd5eb71160b237e9c31f0bccfe2322804620074c0899205
checksum: 10c0/8ff2051fbc3c75e25dd5c19c28203c3f337d4abc33f16a06b6ca16cd0f18e8e78342806096a3ebb5099e68fdd8e247d6826bb1ffc2c645c62345d0c6515962b9
languageName: node
linkType: hard

Expand Down Expand Up @@ -12567,7 +12567,7 @@ __metadata:
version: 0.0.0-use.local
resolution: "eigen@workspace:."
dependencies:
"@artsy/cohesion": "npm:4.328.0"
"@artsy/cohesion": "npm:4.330.0"
"@artsy/icons": "npm:3.62.0"
"@artsy/palette-mobile": "npm:22.1.0"
"@artsy/to-title-case": "npm:1.2.0"
Expand Down