fix(ONYX-1967): add tracking for paste events in search, fix contextScreenOwnerType #13103
+39
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * If text length changes by more than 1 character in a single change event, | ||
| * it's likely a paste (multiple characters added at once) rather than typing | ||
| */ | ||
| const detectPasteEvent = (newQuery: string, previousQuery: string): boolean => { |
Contributor
There was a problem hiding this comment.
You can place this function below the component and have a more specific name, like detectInputPasteEvent.
| return lengthDifference > 1 | ||
| } | ||
|
|
||
| useEffect(() => { |
Contributor
There was a problem hiding this comment.
I feel like this useEffect is doing more than it should. We have now:
- query length event and reset
- on mount setting refs
- check if a paste occurred and track it
I'd think of splitting this into 3 different useEffects, each one with its specific context, for a better separation of concerns.
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves ONYX-1967
Description
This PR:
PR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.