-
Notifications
You must be signed in to change notification settings - Fork 593
chore(ONYX-1956): edit title of the latest auction results screen to use Palette AnimatedHeader #13144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore(ONYX-1956): edit title of the latest auction results screen to use Palette AnimatedHeader #13144
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR refactors auction results screens to use Palette's AnimatedHeader component instead of a custom floating header implementation. The change converts a SectionList-based implementation to a FlatList-based one with manual sticky header management.
Changes:
- Replaced custom floating header with Screen.AnimatedHeader and Screen.StickySubHeader components
- Converted SectionList to FlatList with custom viewability tracking for sticky section headers
- Removed ListHeaderComponent prop and floatingHeaderTitle prop from AuctionResultsList
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 8 comments.
| File | Description |
|---|---|
| AuctionResultsForArtistsYouCollect.tsx | Updated to use Screen.AnimatedHeader and Screen.Body wrapper components |
| AuctionResultsScreenWrapper.tsx | Updated to use Screen.AnimatedHeader and Screen.Body wrapper components, removed ListHeader usage |
| AuctionResultsList.tsx | Major refactoring from SectionList to FlatList with custom sticky header logic and viewability tracking |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| if (index === 0 && item.type === "section-header") { | ||
| // Skip rendering the first section header since it's sticky | ||
| return null |
Copilot
AI
Jan 13, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Skipping the first section header (index === 0) assumes that the first item is always a section header. If the auctionResults array is empty or in an unexpected state, this could cause issues. Consider checking if the item type is 'section-header' rather than just checking the index.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is correct - given the current flatListData builder, for a non-empty auctionResults the code always pushes a section header before the group's items, so the first element will be a "section-header"
Co-authored-by: Copilot <[email protected]>
This PR contains the following changes:
|
This PR resolves ONYX-1956
Description
Updated the header of the auction results screens to use Palette's
Screen.AnimatedHeaderandScreen.StickySubHeader.To enable
Screen.AnimatedHeaderandScreen.StickySubHeader, I replaced theAnimated.SectionListcomponent withScreen.FlatList. This required additional adjustments to preserve the existing sticky auction-date component behavior.Simulator.Screen.Recording.-.iPhone.13.mini.-.2026-01-16.at.16.20.13.mp4
auctions.screens.header.webm
PR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
Screen.AnimatedHeaderandScreen.StickySubHeaderiOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.