chore(deps): bump react-native 0.70.13 #9189

araujobarret · 2023-08-28T08:21:22Z

Description

This PR bumps react-native to 0.70.13. One blocker I've found for Android was the outdated tipsi-stripe library, ~~I replaced it with the official library making the adjustments and adjusting the tests~~ the solution was to add jetifier to the install script as we do in the android build script.
This PR is divided into 3 commits:

1st: rn-diff from upgrade-helper
2nd: ~~tipsi-stripe replacement with @stripe/react-native~~ reverted on 50fba80
3rd: Fix missing values used in XML and bump kotlin version to 1.8.0.
4th: replaces Dimensions.removeEventListener with the new format, this was generating some errors and breaking the tests

PR Checklist

I have tested my changes on iOS and Android.
I hid my changes behind a feature flag, or they don't need one.
I have included screenshots or videos, or I have not changed the UI.
I have added tests, or my changes don't require any.
I added an app state migration, or my changes do not require one.
I have documented any follow-up work that this PR will require, or it does not require any.
I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

I would like at least one of the reviewers to run this PR on the simulator or device.

Changelog updates

Cross-platform user-facing changes

bump react-native to 0.70.13 - araujobarret

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

ArtsyOpenSource · 2023-08-28T08:25:33Z

This PR contains the following changes:

Cross-platform user-facing changes (bump react-native to 0.70.13 - araujobarret)

Generated by 🚫 dangerJS against 516b6ca

MounirDhahri

Niiiiiiice 🔥

gkartalis

woohoo, excited to test it out

araujobarret · 2023-08-28T15:13:31Z

Android release builds are broken in Android because of the Sentry: getsentry/sentry-java#2601
We need to upgrade Sentry to enable this PR 🧽.

gkartalis · 2023-08-29T09:43:14Z

Created a ticket for upgrading sentry here -> https://artsyproduct.atlassian.net/browse/PHIRE-207

brainbicycle · 2023-08-29T13:30:14Z

src/app/Components/Bidding/Screens/ConfirmBid/index.tsx

+        state: billingAddress?.state,
+        postalCode: billingAddress?.postalCode,
+        country: billingAddress?.country.shortName,
+      },


src/app/Components/Bidding/Screens/CreditCardForm.tests.tsx

brainbicycle

So a major react native upgrade, a major sentry upgrade and you got us off a forked dependency? Legend 💪

Awesome work.

I am wondering if it might make sense to separate out the stripe change into a separate pr similar to the sentry change just to keep the separation clean in case something goes wrong. Otherwise this looks great.

Thanks for doing this!

araujobarret · 2023-08-29T13:37:59Z

I wondered that about Stripe too, but tipisi-stripe was breaking Android(during build time) with some weird Java stuff, then the upgrade seemed like a quick win given no breaking changes.
@gkartalis and I will be doing some QA once the betas are ready in the offer/buy/auction flow to make sure everything is in order, feel free to try out the betas once they're ready too 👍

brainbicycle · 2023-08-29T13:40:14Z

I wondered that about Stripe too, but tipisi-stripe was breaking Android(during build time) with some weird Java stuff, then the upgrade seemed like a quick win given no breaking changes.
@gkartalis and I will be doing some QA once the betas are ready in the offer/buy/auction flow to make sure everything is in order, feel free to try out the betas once they're ready too 👍

yeah I hear that not saying not to do the stripe change, just if possible put it into a separate PR and merge first, that way if there is breakage with credit cards or something down the line it is easy to isolate

araujobarret · 2023-08-29T13:48:56Z

Actually, I can do it that way, not sure if kotlin bump would work with the old React native version but I can try separating it for a revert in case of issues.

damassi · 2023-08-29T16:20:36Z

Amazing @araujobarret!!

This reverts commit 9152b92.

araujobarret · 2023-08-30T09:51:56Z

@brainbicycle I was working on retiring tipsi in another branch but found a blocker when replacing it with official stripe library(stripe/stripe-react-native#1044).

The solution was to rever tipisi commit here and add jetifier to the install script to fix android -> androidx packaging translation from tipsi, with that the builds are 100% fine.

Going to generate the betas to test one more time and if everything is fine merge this PR.

araujobarret requested review from damassi, MounirDhahri, gkartalis and brainbicycle August 28, 2023 08:21

araujobarret self-assigned this Aug 28, 2023

MounirDhahri previously approved these changes Aug 28, 2023

View reviewed changes

araujobarret dismissed MounirDhahri’s stale review via efb0dc3 August 28, 2023 09:17

gkartalis reviewed Aug 28, 2023

View reviewed changes

araujobarret mentioned this pull request Aug 29, 2023

chore(sentry): bump sentry to v5 #9191

Merged

8 tasks

araujobarret force-pushed the araujobarret/chore/rn-bump-0.70.13 branch from efb0dc3 to b6af64d Compare August 29, 2023 12:44

brainbicycle reviewed Aug 29, 2023

View reviewed changes

src/app/Components/Bidding/Screens/CreditCardForm.tests.tsx Outdated Show resolved Hide resolved

brainbicycle reviewed Aug 29, 2023

View reviewed changes

araujobarret added 6 commits August 30, 2023 11:41

chore: rn upgrade diff

ae777b7

chore: remove tipsi-stripe in favor of official lib

4a35a30

chore: fix android xml values and bump kotlin version

6171814

refactor: fix dimensions event removal deprecation handler

82e666e

Revert "chore: remove tipsi-stripe in favor of official lib"

50fba80

This reverts commit 9152b92.

chore: update pods after tipsi revert

516b6ca

araujobarret force-pushed the araujobarret/chore/rn-bump-0.70.13 branch from b6af64d to 516b6ca Compare August 30, 2023 09:47

araujobarret merged commit 8d84210 into main Aug 30, 2023

araujobarret deleted the araujobarret/chore/rn-bump-0.70.13 branch August 30, 2023 10:53

gkartalis mentioned this pull request Aug 30, 2023

chore: cleanup of iOS intl polyfills #9202

Merged

8 tasks

brainbicycle mentioned this pull request Jul 10, 2024

chore(deps): replace tipsi with official stripe lib #10451

Merged

8 tasks

MounirDhahri mentioned this pull request Nov 7, 2024

RFC: Trial Expo in Energy and/or Palette-Mobile, Spike on Eigen Risks, Rewards and Effort artsy/README#543

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore(deps): bump react-native 0.70.13 #9189

chore(deps): bump react-native 0.70.13 #9189

Uh oh!

araujobarret commented Aug 28, 2023 •

edited

Loading

Uh oh!

ArtsyOpenSource commented Aug 28, 2023 •

edited

Loading

Uh oh!

MounirDhahri left a comment

Uh oh!

gkartalis left a comment

Uh oh!

araujobarret commented Aug 28, 2023

Uh oh!

gkartalis commented Aug 29, 2023

Uh oh!

brainbicycle Aug 29, 2023

Uh oh!

Uh oh!

brainbicycle left a comment •

edited

Loading

Uh oh!

araujobarret commented Aug 29, 2023 •

edited

Loading

Uh oh!

brainbicycle commented Aug 29, 2023

Uh oh!

araujobarret commented Aug 29, 2023

Uh oh!

damassi commented Aug 29, 2023

Uh oh!

araujobarret commented Aug 30, 2023

Uh oh!

Uh oh!

chore(deps): bump react-native 0.70.13 #9189

chore(deps): bump react-native 0.70.13 #9189

Uh oh!

Conversation

araujobarret commented Aug 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

PR Checklist

To the reviewers 👀

Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

Uh oh!

ArtsyOpenSource commented Aug 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

This PR contains the following changes:

Uh oh!

MounirDhahri left a comment

Choose a reason for hiding this comment

Uh oh!

gkartalis left a comment

Choose a reason for hiding this comment

Uh oh!

araujobarret commented Aug 28, 2023

Uh oh!

gkartalis commented Aug 29, 2023

Uh oh!

brainbicycle Aug 29, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

brainbicycle left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

araujobarret commented Aug 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

brainbicycle commented Aug 29, 2023

Uh oh!

araujobarret commented Aug 29, 2023

Uh oh!

damassi commented Aug 29, 2023

Uh oh!

araujobarret commented Aug 30, 2023

Uh oh!

Uh oh!

araujobarret commented Aug 28, 2023 •

edited

Loading

ArtsyOpenSource commented Aug 28, 2023 •

edited

Loading

brainbicycle left a comment •

edited

Loading

araujobarret commented Aug 29, 2023 •

edited

Loading