fix: canonical URLs in the Partner app #16629
Open
+133
−32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
PartnerMetacomponent to use the router's current URL to set the canonical URL for each of the sub-pages in the Partner app:/partner/:partnerId/shows/partner/:partnerId/viewing-rooms/partner/:partnerId/works/partner/:partnerId/artists/partner/:partnerId/articles/partner/:partnerId/contactEach of these is currently referencing
/partner/:partnerIdas its canonical URL, and after this PR they will each be self-referencing instead. For those pages with pagination, thepage=Nquery param will be included in the URL for pages > 1.This PR also sneaks in a refactor. I noticed that there is some logic to set the canonical URL to an artist's page when an
artistIdis present in the URL. However, the route that anticipates anartistidis redirecting to the/partner/:partnerId/artist#:artistIdroute without rendering, so this is dead code:cc: @artsy/diamond-devs