fix: implement proper TurboModule support for new architecture #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the implementation to correctly use TurboModule APIs: - iOS: Implement getConstants/constantsToExport with typed ModuleConstants return type - JS: Use TurboModule spec instead of legacy NativeModules API 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
MounirDhahri
approved these changes
Dec 19, 2025
Member
|
Thank you @brainbicycle |
Support both old and new React Native architectures by using preprocessor directives in iOS native code and falling back to NativeModules when TurboModules are unavailable in JavaScript. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
Member
|
@brainbicycle can we merge this 👀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes args not being populated on iOS side on new architecture.
the
getConstants()defined in the typescript spec is reserved keyword on modules so we have to use the new arch method signatures in order to get the callbacks.Follow-ups
constantsToExportmethod and update the exported types in index.ts