chore: rename app to rnstarter + fix setup:oss keys filenames - #54
Merged
Conversation
setup:oss keys fix (was breaking yarn ios): - react-native-keys reads per-env files (keys.development.json for debug, keys.production.json for release), NOT keys.json — the old script created keys.json, so builds failed with ENOENT keys.development.json. Create both env files from keys.example.json instead. Fix the same wrong instruction in the Getting Started docs. Also note that switching app.json config needs a clean prebuild (stale native folders cause 'resource color/iconBackground not found'). Rename the template app from the leftover 'Energy' to 'rnstarter': - app.json name/displayName/expo.name/scheme + iOS bundleIdentifier and Android package (net.artsy.energy → net.artsy.rnstarter). - Update the e2e references that target the app: launch-smoke.ad 'open Energy' → 'open rnstarter', android-e2e.sh APP_ID, and the e2e/docs mentions. - Left the 'mirroring Eigen/Energy' inspiration comments as-is (they reference Artsy's production app, not this one). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KPWjhmaeq8DnsiiFD9Eg7A
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Two fixes surfaced while running the app after
yarn setup:oss.1.
setup:osscreated the wrong keys file (brokeyarn ios)react-native-keysreads per-environment files —keys.development.json(debug) andkeys.production.json(release), notkeys.json. The build failed withENOENT: keys.development.json.scripts/setup-ossnow creates both env files fromkeys.example.json, and the Getting Started docs are corrected (they wrongly saidcp keys.example.json keys.json). Added a note that switchingapp.jsonconfig needs a clean prebuild, since a staleandroid/folder causes theresource color/iconBackground not founderror (unrelated to this repo — it was a leftover native folder).2. Rename the template app
Energy→rnstarterThe app was still named "Energy" (leftover from being modeled on Folio/Energy).
app.json:name/displayName/expo.name/scheme, iOSbundleIdentifierand Androidpackage(net.artsy.energy→net.artsy.rnstarter).launch-smoke.ad(open Energy→open rnstarter),android-e2e.shAPP_ID, and the e2e/docs mentions.Notes for reviewers
yarn prebuild, oryarn ios:clean/yarn android:clean) so the renamed bundle id/package and icon resources regenerate.open rnstarteron its nextworkflow_dispatchrun.🤖 Generated with Claude Code
Generated by Claude Code