refactor: simplify env config to a local .env - #57
Merged
Conversation
….env.dev) The app reads only EXPO_PUBLIC_* vars (Unleash URL/key, Sentry DSN), which Expo inlines from a local .env at build time — the old prepare-env-vars S3 → .env.shared → .env.dev merge (a react-native-config leftover) wrote a file Expo never loads. - Add tracked .env.example with the EXPO_PUBLIC_* keys (all optional; app boots fine blank — Unleash/Sentry are gated off when unset). - setup:oss and setup:artsy now seed .env from .env.example if missing. - Remove scripts/prepare-env-vars; setup:artsy keeps the S3 font download only. - Rewrite docs/environment_variables_configuration.md for the .env approach and clarify secrets live in keys.*.json (react-native-keys), not .env. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KPWjhmaeq8DnsiiFD9Eg7A
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The app only reads
EXPO_PUBLIC_*vars (Unleash URL/key, Sentry DSN), which Expo inlines from a local.envat build time. The oldprepare-env-varsflow (S3 →.env.shared→ merge into.env.dev) is a leftover fromreact-native-configand wrote a file Expo never loads — so it was effectively dead..env.examplewith theEXPO_PUBLIC_*keys (all optional; the app boots fine blank — Unleash and Sentry are gated off when unset).yarn setup:ossandyarn setup:artsynow seed.envfrom.env.exampleif missing.scripts/prepare-env-vars;setup:artsykeeps only the S3 font download.docs/environment_variables_configuration.mdfor the.envapproach and clarify that secrets live inkeys.*.json(react-native-keys), not.env.No S3 env object needed anymore.
🤖 Generated with Claude Code
Generated by Claude Code