fix unterminated quotes in a long names

Author: arttor

examples/app/templates/my-secret-vars.yaml

@@ -5,6 +5,8 @@ metadata:
   labels:
   {{- include "app.labels" . | nindent 4 }}
 data:
+  ELASTIC_FOOBAR_HUNTER123_MEOWTOWN_VERIFY: {{ required "mySecretVars.elasticFoobarHunter123MeowtownVerify is required" .Values.mySecretVars.elasticFoobarHunter123MeowtownVerify | b64enc
+    | quote }}
   VAR1: {{ required "mySecretVars.var1 is required" .Values.mySecretVars.var1 | b64enc
     | quote }}
   VAR2: {{ required "mySecretVars.var2 is required" .Values.mySecretVars.var2 | b64enc

examples/app/values.yaml

@@ -37,6 +37,7 @@ myConfigProps:
 mySecretCa:
   caCrt: ""
 mySecretVars:
+  elasticFoobarHunter123MeowtownVerify: ""
   str: ""
   var1: ""
   var2: ""

pkg/format/fix_quotes.go

@@ -0,0 +1,26 @@
+package format
+
+import (
+	"strings"
+)
+
+// FixUnterminatedQuotes check for Unterminated Quotes in helm templated strings
+// See https://github.com/arttor/helmify/issues/12
+func FixUnterminatedQuotes(in string) string {
+	sb := strings.Builder{}
+	hasUntermQuotes := false
+	lines := strings.Split(in, "\n")
+	for i, line := range lines {
+		if hasUntermQuotes {
+			line = " " + strings.TrimSpace(line)
+			hasUntermQuotes = false
+		} else {
+			hasUntermQuotes = strings.Count(line, "\"")%2 != 0
+		}
+		sb.WriteString(line)
+		if !hasUntermQuotes && i != len(lines)-1 {
+			sb.WriteString("\n")
+		}
+	}
+	return sb.String()
+}

pkg/format/fix_quotes_test.go

@@ -0,0 +1,57 @@
+package format
+
+import "testing"
+
+func TestFixUnterminatedQuotes(t *testing.T) {
+	tests := []struct {
+		name string
+		in   string
+		want string
+	}{
+		{
+			name: "remove line break for unterminated quotes",
+			in: `apiVersion: v1
+kind: Secret
+metadata:
+  name: {{ include "app.fullname" . }}-my-secret-vars
+  labels:
+  {{- include "app.labels" . | nindent 4 }}
+data:
+  ELASTIC_FOOBAR_HUNTER123_MEOWTOWN_VERIFY: {{ required "mySecretVars.elasticFoobarHunter123MeowtownVerify
+    is required" .Values.mySecretVars.elasticFoobarHunter123MeowtownVerify | b64enc
+    | quote }}
+  VAR1: {{ required "mySecretVars.var1 is required" .Values.mySecretVars.var1 | b64enc
+    | quote }}
+  VAR2: {{ required "mySecretVars.var2 is required" .Values.mySecretVars.var2 | b64enc
+    | quote }}
+stringData:
+  str: {{ required "mySecretVars.str is required" .Values.mySecretVars.str | quote
+    }}
+type: opaque`,
+			want: `apiVersion: v1
+kind: Secret
+metadata:
+  name: {{ include "app.fullname" . }}-my-secret-vars
+  labels:
+  {{- include "app.labels" . | nindent 4 }}
+data:
+  ELASTIC_FOOBAR_HUNTER123_MEOWTOWN_VERIFY: {{ required "mySecretVars.elasticFoobarHunter123MeowtownVerify is required" .Values.mySecretVars.elasticFoobarHunter123MeowtownVerify | b64enc
+    | quote }}
+  VAR1: {{ required "mySecretVars.var1 is required" .Values.mySecretVars.var1 | b64enc
+    | quote }}
+  VAR2: {{ required "mySecretVars.var2 is required" .Values.mySecretVars.var2 | b64enc
+    | quote }}
+stringData:
+  str: {{ required "mySecretVars.str is required" .Values.mySecretVars.str | quote
+    }}
+type: opaque`,
+		},
+	}
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			if got := FixUnterminatedQuotes(tt.in); got != tt.want {
+				t.Errorf("FixUnterminatedQuotes() = %v, want %v", got, tt.want)
+			}
+		})
+	}
+}

pkg/processor/secret/secret.go

@@ -1,6 +1,7 @@
 package secret
 
 import (
+	"github.com/arttor/helmify/pkg/format"
 	"io"
 	"strings"
 	"text/template"
@@ -88,6 +89,7 @@ func (d secret) Process(appMeta helmify.AppMetadata, obj *unstructured.Unstructu
 			return true, nil, err
 		}
 		data = strings.ReplaceAll(data, "'", "")
+		data = format.FixUnterminatedQuotes(data)
 	}
 
 	templatedData = map[string]string{}
@@ -108,6 +110,7 @@ func (d secret) Process(appMeta helmify.AppMetadata, obj *unstructured.Unstructu
 			return true, nil, err
 		}
 		stringData = strings.ReplaceAll(stringData, "'", "")
+		stringData = format.FixUnterminatedQuotes(stringData)
 	}
 
 	return true, &result{

test_data/sample-app.yaml

@@ -166,6 +166,7 @@ type: opaque
 data:
   VAR1: bXlfc2VjcmV0X3Zhcl8x
   VAR2: bXlfc2VjcmV0X3Zhcl8y
+  ELASTIC_FOOBAR_HUNTER123_MEOWTOWN_VERIFY: bXlfc2VjcmV0X3Zhcl8y
 stringData:
   str: |
     some big not so secret string with