Fix single quotes dropped #155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arttor
requested changes
Nov 16, 2024
Owner
arttor
left a comment
arttor
left a comment
There was a problem hiding this comment.
Overall looks really good, thank you for adjusting test examples. I had only one comment related to unit tests.
Contributor
Author
|
I added all the edge cases that came to my mind |
arttor
approved these changes
Nov 17, 2024
Owner
|
@Greendor1234 thank you for your contribution. The changes are available in v0.4.15 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To close issue #151
According to what it's written in the comments, I introduced a regular expression that replaces the quotes for anything with {{}}.
I checked the results, it seems to work.