-
Notifications
You must be signed in to change notification settings - Fork 158
feat: add missing fields to values #175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
modify serviceAccount to be able to use externally created SA Signed-off-by: David Sabatie <[email protected]>
|
Hello @arttor, can you review this PR please ? We need it 🙏 |
Signed-off-by: David Sabatie <[email protected]>
|
@arttor Thank you for the review, I fixed your point. I also have also backported the automount field from a blank helm chart generated with the latest helm.sh release (helm create ...). |
|
@Greendor1234 there is a lint errors on CI |
|
Hi @arttor and @Greendor1234 , do I have something to do to fix the CI ? |
|
yes, there are linting errors: see: https://github.com/arttor/helmify/actions/runs/18792232809/job/53646170677?pr=175 |
Signed-off-by: David Sabatie <[email protected]>
|
@arttor I fixed the linter issues |
Signed-off-by: David Sabatie <[email protected]>
|
@arttor All seems ok, thank you for your review |
|
this seems to have broken |
modify serviceAccount to be able to use externally created SA.
It also add nodeSelector, tolerations and topologySpreadContraints fields to values.yaml (with empty values by default).
closes #174