Skip to content

Conversation

@golgoth31
Copy link
Contributor

@golgoth31 golgoth31 commented Oct 14, 2025

modify serviceAccount to be able to use externally created SA.
It also add nodeSelector, tolerations and topologySpreadContraints fields to values.yaml (with empty values by default).

closes #174

modify serviceAccount to be able to use externally created SA

Signed-off-by: David Sabatie <[email protected]>
@matthisholleville
Copy link

Hello @arttor, can you review this PR please ? We need it 🙏

@golgoth31
Copy link
Contributor Author

@arttor Thank you for the review, I fixed your point. I also have also backported the automount field from a blank helm chart generated with the latest helm.sh release (helm create ...).

@golgoth31 golgoth31 requested a review from arttor October 24, 2025 21:16
@arttor
Copy link
Owner

arttor commented Oct 25, 2025

@Greendor1234 there is a lint errors on CI

@golgoth31
Copy link
Contributor Author

Hi @arttor and @Greendor1234 , do I have something to do to fix the CI ?

@arttor
Copy link
Owner

arttor commented Nov 1, 2025

yes, there are linting errors:

  Error: Error return value of `json.Unmarshal` is not checked (errcheck)
  Error: Error return value of `json.Unmarshal` is not checked (errcheck)
  Error: Error return value of `encoding/json.Marshal` is not checked (errchkjson)
  Error: Error return value of `encoding/json.Marshal` is not checked (errchkjson)

see: https://github.com/arttor/helmify/actions/runs/18792232809/job/53646170677?pr=175

Signed-off-by: David Sabatie <[email protected]>
@golgoth31
Copy link
Contributor Author

@arttor I fixed the linter issues

Signed-off-by: David Sabatie <[email protected]>
@golgoth31
Copy link
Contributor Author

@arttor All seems ok, thank you for your review

@arttor arttor merged commit 4f6d16b into arttor:main Nov 6, 2025
1 check passed
@golgoth31 golgoth31 deleted the feat/add-missing-values branch November 6, 2025 14:33
@harrygodwin10
Copy link

this seems to have broken -preserve-ns for ServiceAccounts since being released in 0.4.19, per #179 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

support serviceAccount helper

4 participants