reenable consteval on from_string test #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Author
|
@UF4007 Do You work on windows (I work on linux and I try to avoid runing >VM with win) ? Can You see why from_string fails consteval testing on msvc only ? |
Contributor
|
It seems MSVC does not support static constexpr variables within functions. |
Owner
Author
|
@UF4007 WHY DID YOU merge ? |
arturbac
commented
May 10, 2025
|
|
||
| namespace string | ||
| { | ||
| constexpr fixed_internal power[14]{ |
Owner
Author
There was a problem hiding this comment.
this is wrong it should be inline constexpr as constexpr defaults to static,when in a header You have static then it is ODR when used in multiple translation units
|
|
||
| inline constexpr isdigit_t isdigit; | ||
|
|
||
| namespace string |
Owner
Author
There was a problem hiding this comment.
this is potentialy coliding with string in name.
It should be in a fixedmath::detail namespace
Contributor
|
Sorry, I am too hurried |
Owner
Author
|
Ill fix that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.