Feature/national check digits validation#169
Open
RedSlowpoke wants to merge 4 commits intoarturmkrtchyan:masterfrom
Open
Feature/national check digits validation#169RedSlowpoke wants to merge 4 commits intoarturmkrtchyan:masterfrom
RedSlowpoke wants to merge 4 commits intoarturmkrtchyan:masterfrom
Conversation
623b61c to
127273d
Compare
…check-digits-validation # Conflicts: # src/test/java/org/iban4j/TestDataHelper.java
Contributor
Author
|
@hajk1 Could you kindly review my PR and tell me whether this approach is suitable for the project? |
Collaborator
|
@RedSlowpoke The general approach is right. However there is an active issue and development related to this feature here. |
Contributor
Author
|
Let me know if anything is expected from me to make this happen @hajk1 |
Collaborator
|
@RedSlowpoke I will review till end of the month. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Previously, the iban4j library only performed standard IBAN validation (format, length, and international check digit validation). However, many countries have additional national check digit validation rules that provide an extra layer of validation for their domestic banking systems. This change extends the library to support country-specific national check digit validation rules, providing more comprehensive IBAN validation capabilities for applications that need to ensure the highest level of accuracy when processing international bank account numbers.
Changes
Core Infrastructure
validateWithCountryRules,isValidWithCountryRules)National Check Digit Algorithms
Implemented validation algorithms for 20 countries with separate documentation and implementation files:
docs/references/check digits/src/main/java/org/iban4j/countryrules/algorithms/Utility Classes
COUNTRY_RULES_FAILEDviolation typeDocumentation
API Enhancements
Tests
Unit Tests
Test Coverage
Impact
Enhanced Validation Capabilities
Developer Experience
Performance Considerations
Backward Compatibility
Future Extensibility