Add BBAN structure for 3 registered and 11 unregistered IBAN countries#35
Open
reva wants to merge 2 commits intoarturmkrtchyan:masterfrom
Open
Add BBAN structure for 3 registered and 11 unregistered IBAN countries#35reva wants to merge 2 commits intoarturmkrtchyan:masterfrom
reva wants to merge 2 commits intoarturmkrtchyan:masterfrom
Conversation
Owner
|
@reva thanks for your contribution. Can you please add test data as well ? See the example here: https://github.com/arturmkrtchyan/iban4j/blob/master/src/test/java/org/iban4j/TestDataHelper.java#L26 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added some missing countries, three of which are described in the official ISO-13616 document. The rest are as described in the IBAN Wikipedia article, for which the source is the Nordea bank. (The codes for Ukraine and Iran were already included from that source)