Added SEPA support to IbanUtil and Countrycodes#41
Open
4braincells wants to merge 5 commits intoarturmkrtchyan:masterfrom
Open
Added SEPA support to IbanUtil and Countrycodes#414braincells wants to merge 5 commits intoarturmkrtchyan:masterfrom
4braincells wants to merge 5 commits intoarturmkrtchyan:masterfrom
Conversation
Author
|
Set JAVA_HOME on the jenkins and rerun the checks 👎 |
added 2 commits
November 20, 2019 17:30
Time has passed :-)
mmorel-35
reviewed
Dec 11, 2019
| public String getName() { | ||
| return name; | ||
| } | ||
| private final String sepaIdentifier; |
There was a problem hiding this comment.
Why don't you use a boolean type for this field ?
Author
There was a problem hiding this comment.
Well, no special reason. We got used to use literals in many places in our application, so this was just straightforward decision. It just had to do it's job ... :-)
If you guys vote for bool, I'll refactor ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As stated in the comment from last week, I added SEPA support to IbanUtil and Countrycodes and would like you to merge this.