Generate an iban with a country code chosen at random from a list.#63
Open
dieks wants to merge 1 commit intoarturmkrtchyan:masterfrom
Open
Generate an iban with a country code chosen at random from a list.#63dieks wants to merge 1 commit intoarturmkrtchyan:masterfrom
dieks wants to merge 1 commit intoarturmkrtchyan:masterfrom
Conversation
…domly from a given set of country codes.
ccostin93
reviewed
Nov 25, 2020
| public final static class Builder { | ||
|
|
||
| private CountryCode countryCode; | ||
| private List<CountryCode> countryCodes; |
Contributor
There was a problem hiding this comment.
I would delete private CountryCode countryCode; and replace it with instantiating the build with a singletonList(countryCode).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Making it possible to generate an iban with a country code chosen randomly from a given set of country codes.
In case the specific country code of the iban to generate is one of a set of possible codes, you could pass these possible codes as a list to the builder.