Improve Iban.Builder validation#80
Open
ccostin93 wants to merge 2 commits intoarturmkrtchyan:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I extended the Iban.Builder validation to be based on BbanStructure of the passed country.
If some entry is missing, the validation will throw an exception with the missing field. This makes sense because the BbanStructure will be used in the next steps
formatIban -> formatBbanand there is no reason to go to this step if the given data is not enough to generate a valid IBAN.Changes:
UnsupportedCountryExceptionto expect just the country code. The error message was moved to the exception itself and is based on the passed country code.Related issues:
@hajk1 This PR also relates to your proposed fix in: #75