Add markers and fixed intializations, fix an error#15
Draft
almdudleer wants to merge 4 commits intoalmdudleer/formattingfrom
Draft
Add markers and fixed intializations, fix an error#15almdudleer wants to merge 4 commits intoalmdudleer/formattingfrom
almdudleer wants to merge 4 commits intoalmdudleer/formattingfrom
Conversation
Error: "no match for ‘operator=’ (operand types are ‘arma::subview_row<double>’ and ‘<brace-enclosed initializer list>’)"
almdudleer
commented
Jun 21, 2023
| marker_means <- lapply(markers_list, function(x) { | ||
| sel <- x[x %in% rownames(self$new_points)] | ||
| if (sum(sel) == 0) stop("One or more cell types has zero markers present") | ||
| colMeans(self$new_points[sel, ]) |
Collaborator
Author
There was a problem hiding this comment.
Essentially, markers initialization is this line only. For the set of marker genes for each cell type, we take the mean of the corresponding self$new_points column, and that is the X. Judging by the plots, it works fine, and proportions, generated from that seem to be good.
almdudleer
commented
Jun 21, 2023
| self$setInitParamsByX() | ||
| }, | ||
|
|
||
| setInitParamsByX = function() { |
Collaborator
Author
There was a problem hiding this comment.
However the basis generated from this function doesn't seem to be good in 10d:
Here's the math for it:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.