allow override of docker image

[gdw2]

Use case:

My meteor app depends on having the graphicsmagick binary installed, so I want to use a docker image, based off meteord, that contains the dependency.

[arunoda]

It is mup.json file. Not the settings.json file.
Also, show a code sample on to do it. Just having the dockerImage key is enough.

Also, add a link to to MeteorD

[arunoda]

May be you can link also another document on how to extend MeteorD. May be a blog post of yours.
Anyway, that can be done later.

[arunoda]

Mention me once you done changes. It's hard to track it otherwise.
On 2015 නොවැ 4, බදාදා at පෙ.ව. 12.24 gdw2 notifications@github.com wrote:

This may address #728 zodern/meteor-up#728

—
Reply to this email directly or view it on GitHub
zodern/meteor-up#728 (comment).

[gdw2]

Thanks for the feedback. Will fix this week.

[bompi88]

+1

[MichaelJCole]

Hey, I was just about to make these same changes. @gdw2 did they work well for you?

@gdw2 @arunoda is there any help I can offer to move this over the finish line?

[gdw2]

@arunoda . I addressed your review comments.
@MichaelJCole . It has worked well for me.

[v3rron]

@arunoda can you pls accept this pull request? thanks

[bompi88]

@gdw2 @arunoda Shouldn't this be configurable for all deploy targets as well as the general option?

[bompi88]

Looks like this will be the new mup? Haven't tried it with custom docker image yet, though.

[MasterJames]

It will have that. I'm pretty sure I saw a post in the new still under development version to add custom docker images.

[comigor]

Oh please merge it already

[MasterJames]

This account in general has been depreciated and mupx has almost been ported to kadirahq.
For the record I am no an official representative.
All unmerged PRs need to be ported to the new version. I believe there will be a more regorious need to comply with dev&submission methods/requirements, which are still being outlined for Mantra in general. Basically meaning tests are now needed to accept Pull Requests. I don't think any or many PRs here do, mine don't.

[comigor]

@MasterJames oh, nice, I wasn't aware of that. Thank you!

[eskan]

very useful PR : @arunoda may you merge it ?
thanks

[MasterJames]

No PRs have been merged here for a very long time. It is considered the stable version partly for that reason.
New development is at kadirahq/meteor-up if there's a PR of interest here that is still needed in the new version then it could be redone for consideration there. It wouldn't hurt to ask the devs there if it's needed and desired first.
Oh I already commented here.