feat: display live search results count in exercise search - #20
Open
sagnikonly wants to merge 1 commit into
Open
feat: display live search results count in exercise search#20sagnikonly wants to merge 1 commit into
sagnikonly wants to merge 1 commit into
Conversation
5 tasks
|
Superseded by #28 (search result count in Library + picker, with |
|
Search result counts are in #28. Please close in favor of that PR. |
|
Heads up: openGym has moved to GitLab. The GitHub repo is no longer maintained (the account was suspended, so it's out of my hands). Please re-open this issue/PR on GitLab so it doesn't get lost, I'll pick it up there. Questions, help and roadmap discussion now happen in Discord: Sorry for the noise, and thanks for sticking around. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a live search result count badge to the right side of the exercise search text box in both the Add Exercise sheet (
ExercisePicker) and the Exercises Library view (Library).Summary of Changes:
var(--surface-3)/ theme-appropriate badge pill) and ensures comfortable right-padding (56px) so long search terms do not overlap the badge.Verification:
npm test- 192/192 tests pass).