Add .gitignore; stop tracking node_modules, dist, data, and media - #44
Open
iamgroot400 wants to merge 3 commits into
Open
Add .gitignore; stop tracking node_modules, dist, data, and media#44iamgroot400 wants to merge 3 commits into
iamgroot400 wants to merge 3 commits into
Conversation
Load starter plan used to hand you one fixed Push/Pull/Legs routine. It now opens a picker with four templates (PPL, Upper/Lower, Full Body, 5x5), each built from the same generic spec -> routines/week mapping in lib/starter.js, so adding another plan later is just a new entry, not new plumbing. Addresses the "additional starter plans" item in CONTRIBUTING.md's good-first-issues list.
The repo had no .gitignore, so build output and installed dependencies ended up committed: frontend/node_modules (9,619 files), frontend/dist, plus data/ (the self-hosted instance's session secret, VAPID keypair, and user db) and media/ (the ~140 MB exercise image/gif set fetched at runtime). CONTRIBUTING.md already documents media/ and data/ as gitignored — this makes it true. Files are untracked going forward, not removed from history — a history rewrite is a separate, maintainer-level decision given data/ holds what look like live secrets.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The repo has no
.gitignore, so build output and installed dependencies ended up committed:frontend/node_modules(9,619 files),frontend/dist, plusdata/andmedia/. CONTRIBUTING.md already documentsmedia/anddata/as gitignored ("Don't commit the exercise media (media/) ordata/— they're gitignored") — this PR makes that actually true.Summary
.gitignore(node_modules, build output,data/,media/,.DS_Store,.env)git rm -r --cachedon the now-ignored paths — untracked going forward, files untouched on disk, no history rewriteNote
data/held real instance state (session secret, VAPID keypair, user db) — worth rotating on any instance that shares this history, and possibly a follow-up history rewrite (git filter-repoor similar) if that's a priority; that's a bigger, maintainer-level call so I left it out of this PR. Happy to help with a follow-up if useful.Test plan
ls data/ media/— files still present on disk aftergit rm --cachedgit statusclean, nothing untracked besides the new.gitignore