fix: pin zod-to-json-schema + add teammate communication prompt#17
Conversation
…e communication prompt
|
Caution Review failedPull request was closed or merged during review No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
📝 WalkthroughWalkthroughTwo files were modified: package.json received a new PNPM overrides configuration for zod-to-json-schema version ~3.24.5, and spawner.ts had a new "TEAMMATE COMMUNICATION" section added to the agent prompt with coordination guidelines for teammate interactions. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Descricao
Corrige dois problemas no agent-teams:
Teammate MCP não inicializava:
zod-to-json-schema@3.25.1(puxado pelo@modelcontextprotocol/sdk@1.22.0) tenta importarzod/v3, subpath que só existe nozod@3.25.x. Como o lockfile resolviazod@3.24.4, o server crashava comERR_PACKAGE_PATH_NOT_EXPORTEDantes de responder aoinitialize. O lead funciona porque roda vianpx(deps isoladas), mas o teammate roda vianodedireto no monorepo.Teammates não coordenam contratos de API: O prompt do spawner não instruía teammates a compartilhar contratos (paths, shapes) entre si. Backend e frontend implementavam paths independentes sem comunicação.
Mudanças
pnpm.overridesno root pinnandozod-to-json-schemapara~3.24.5(compatível comzod@3.24.x)send_message,write_artifact, efetch_messagespara coordenação de contratosEtiquetas (Labels)
Motivacao e Contexto
Agent teams spawned teammates que não conseguiam inicializar o MCP server, resultando em tasks que ficavam
pendingpara sempre. Além disso, mesmo quando funcionavam, backend e frontend não conversavam sobre contratos de API.Como Isso Foi Testado?
Testado manualmente enviando JSON-RPC initialize para o teammate MCP server — antes crashava com ERR_PACKAGE_PATH_NOT_EXPORTED, agora responde corretamente.
Analise de Risco e Impacto
Summary by CodeRabbit
New Features
Chores