Avoid SelfResolvingDependency #749
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SelfResolvingDependency has been deprecated in Gradle 8.x and will be removed in Gradle 9.0 BaseNpmSelfResolvingDependency implements this API, as well as Dependency, and SelfResolvingDependencyInternal. Implementing Gradle interfaces like Dependency is asking for trouble, as these APIs are subject to change in Gradle major versions. Plus, implementing these APIs often require also implementing internal types. This commit removes all references to SelfResolvingDependency, and all references to BaseNpmSelfResolvingDependency, which implements SelfResolvingDependency. Instead, it uses public Gradle APIs to create a FileCollectionDependency which lazily installs NPM dependencies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SelfResolvingDependency has been deprecated in Gradle 8.x and will be removed in Gradle 9.0
BaseNpmSelfResolvingDependency implements this API, as well as Dependency, and SelfResolvingDependencyInternal.
Implementing Gradle interfaces like Dependency is asking for trouble, as these APIs are subject to change in Gradle major versions. Plus, implementing these APIs often require also implementing internal types.
BaseNpmSelfResolvingDependencywill be impacted by multiple breaking changes in Gradle 9.0:This commit removes all references to SelfResolvingDependency, and all references to BaseNpmSelfResolvingDependency, which implements SelfResolvingDependency. Instead, it uses public Gradle APIs to create a FileCollectionDependency which lazily installs NPM dependencies.