fix: only apply default object-fit when no CSS class is provided #848
+67
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #283
This PR makes CSS classes work for
object-fitwithout any extra props needed.Problem
The
objectFitprop defaulted to"cover"and was applied as an inline style. Since inline styles have higher specificity than CSS classes, users couldn't overrideobject-fitvia CSS-in-JS libraries or CSS modules.Solution
Only apply the default
object-fit: coverwhen noclassorclassNameprop is provided. This way:object-fit: cover(backward compatible)Not a Breaking Change
Existing code without classes continues to work exactly as before. Only users who pass classes AND want CSS to control object-fit benefit from this change.
Testing
Added tests to verify:
object-fit: coverwhen no classobject-fitwhenclassis providedobject-fitwhenclassNameis providedobjectFitprop works even with class