feat(explorer): v0.8.4 Explorer action workflows — editor launch, guided import, export - #55
Merged
Merged
Conversation
Implements rac/roadmaps/v0.8.x-explorer/v0.8.4-explorer-action-workflow.md. Pins editor resolution from $VISUAL/$EDITOR with a runner seam, the guided import workflow over Core ingest with preview and confirmation, the reusable confirm path, recommendation export, and the v0.8.5 deferrals.
Implements rac/roadmaps/v0.8.x-explorer/v0.8.4-explorer-action-workflow.md. rac.explorer.editor resolves the editor from $VISUAL/$EDITOR and launches it fire-and-forget through a runner seam; the context view gains an e binding to open the current artifact in it, with guidance when none is configured (ADR-024: Explorer never edits).
Implements rac/roadmaps/v0.8.x-explorer/v0.8.4-explorer-action-workflow.md. /import <source> [target] wraps the Core ingest service: conversion runs in a worker with operation feedback, the converted Markdown is previewed with its target path, and nothing is written until the user confirms with y. Import never overwrites and produces the same output as rac ingest (ADR-015); Explorer owns only the workflow.
Implements rac/roadmaps/v0.8.x-explorer/v0.8.4-explorer-action-workflow.md. The recommendations screen gains an x binding that renders the current recommendations to Markdown and writes them through the shared confirm-write screen — preview first, write only on confirmation, never overwriting (Initiative 4).
Implements rac/roadmaps/v0.8.x-explorer/v0.8.4-explorer-action-workflow.md.
Implements rac/roadmaps/v0.8.x-explorer/v0.8.4-explorer-action-workflow.md.
tcballard
force-pushed
the
claude/v0.8.4-explorer-action-workflow
branch
from
June 10, 2026 19:57
02802a1 to
1b517d2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements
rac/roadmaps/v0.8.x-explorer/v0.8.4-explorer-action-workflow.md.Adds:
efrom an artifact's context view opens it in the user's editor ($VISUAL/$EDITOR), launched fire-and-forget; Explorer never edits (ADR-024)/import <source> [target]converts a document via the Core ingest service in a worker (operation feedback), previews the Markdown with its target, and writes only after explicit confirmation, never overwritingxfrom the recommendations view exports them to a Markdown file through the same preview-and-confirm pathRoadmap / ADR Trace
Roadmap:
rac/roadmaps/v0.8.x-explorer/v0.8.4-explorer-action-workflow.md(contract pinned in the first commit)Relevant ADRs and designs:
Scope
Included
rac.explorer.editor— resolve editor from$VISUALthen$EDITOR; launch via a module-level runner seam; guidance when unconfigured or on failure (never raises)ExplorerAdapter.open_in_editor,import_preview,write_import,export_recommendations;state.ImportPreviewContextScreengainse+ a status line;ImportScreen(convert → preview → confirm → write, worker-driven);ConfirmWriteScreen(shared preview/confirm write);RecommendationsScreengainsximportjoins the command registry;ContextScreennow takes the adapter (threaded through all call sites)Excluded (deliberately)
$VISUAL/$EDITORconventionProduct / Architecture Decisions
Popen) so the TUI keeps running — suited to GUI editors the design emphasizes. The runner is a module seam (editor._RUNNER) so tests inject a spy; no real process starts..mdin the current directory; an explicit target overrides.write_importrefuses to overwrite (matchingrac new's no-clobber stance) and creates parent directories.rac ingest(test assertsimport_preview(...).markdown == ingest(...).markdown) — Explorer adds only the workflow.y.ImportPreview(converter="export") and writing throughwrite_import, so the no-overwrite/preview guarantees hold for it too.User-Facing Contract
CLI / Keys
Human Output (interactive)
Opened <path> in <editor>, or guidance to set$EDITORConverting <source>…, then a preview block (Source / Converter / Target / converted Markdown) andPress y to write this file · Esc to cancel, then the resultrecommendations.mdJSON Output
No changes; no new contracts.
Exit Codes
Unchanged:
0session quit ·2not a directory or missingexplorerextra.Verification
Ran
Covered
$VISUALpreferred over$EDITOR; launch passes[*shlex.split(cmd), path]to the runner; unconfigured → guidance;OSError→ recoverable message;ein the context view launches via an injected spy and shows the status, and shows guidance when unsetimport_previewequalsrac ingestoutput; unsupported type and missing source report messages;write_importwrites then refuses to overwrite; the/importflow previews,ywrites the exact bytes,Escwrites nothing, unsupported reports failurexflow previews inConfirmWriteScreenandywritesrecommendations.mdimportdiscoverable and arg-splitting;/helplists all 9 entrieseditor.py(no Textual/Core imports)Review Path
rac/roadmaps/v0.8.x-explorer/v0.8.4-explorer-action-workflow.md— the pinned contractsrc/rac/explorer/editor.py— resolution + launch seamsrc/rac/explorer/adapter.py—open_in_editor,import_preview,write_import,export_recommendationssrc/rac/explorer/screens/import_.py,screens/confirm.py— the worker-driven preview/confirm screenssrc/rac/explorer/screens/context.py,recommendations.py,commands.py,screens/command.py— bindings and routingtests/— editor, adapter, app, commandsdocs/cli.md,CHANGELOG.mdNotes For Reviewer
ContextScreennow requires the adapter (fore); all four call sites were updated. No behavior change to existing navigation.Implementation Process
Implemented with AI assistance under the roadmap contract.
Final scope, review, and acceptance decisions were made by the maintainer.