Skip to content

fix: link replacement for arm architecture #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
azmelanar wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: link replacement for arm architecture #56

azmelanar wants to merge 1 commit into from

Conversation

@azmelanar
Copy link

@azmelanar azmelanar commented Aug 8, 2022

All links for ARM architecture contains arm64 in filename that cannot download and install application properly:

❯ uname -m
arm64

❯ asdf install
curl: (28) Operation timed out after 90004 milliseconds with 13000157 out of 19758608 bytes received
Downloading terraform version 1.2.2 from https://releases.hashicorp.com/terraform/1.2.2/terraform_1.2.2_darwin_arm.zip
curl: (22) The requested URL returned error: 404
Error: terraform version 1.2.2 not found

With this fix:

❯ asdf install
Downloading terraform version 1.2.2 from https://releases.hashicorp.com/terraform/1.2.2/terraform_1.2.2_darwin_arm64.zip
Verifying signatures and checksums
gpg: keybox '/var/folders/n8/r74pjhw110158k29htt871h80000gn/T/asdf_terraform_XXXXXX.eWvTD5Rv/pubring.kbx' created
gpg: /var/folders/n8/r74pjhw110158k29htt871h80000gn/T/asdf_terraform_XXXXXX.eWvTD5Rv/trustdb.gpg: trustdb created
gpg: key 34365D9472D7468F: public key "HashiCorp Security (hashicorp.com/security) <[email protected]>" imported
gpg: Total number processed: 1
gpg:               imported: 1
gpg: Signature made Wed Jun  1 18:50:16 2022 CEST
gpg:                using RSA key 374EC75B485913604A831CC7C820C6D5CD27AB87
gpg: Good signature from "HashiCorp Security (hashicorp.com/security) <[email protected]>" [unknown]
gpg: WARNING: This key is not certified with a trusted signature!
gpg:          There is no indication that the signature belongs to the owner.
Primary key fingerprint: C874 011F 0AB4 0511 0D02  1055 3436 5D94 72D7 468F
     Subkey fingerprint: 374E C75B 4859 1360 4A83  1CC7 C820 C6D5 CD27 AB87
terraform_1.2.2_darwin_arm64.zip: OK
Cleaning terraform previous binaries
Creating terraform bin directory
Extracting terraform archive

Checked file naming for:

@azmelanar azmelanar requested a review from a team as a code owner August 8, 2022 11:31
@smorimoto smorimoto force-pushed the 20220808-install_arm64_arch branch from 00953dc to fad30d7 Compare July 18, 2023 16:44
smorimoto
smorimoto reviewed Jul 18, 2023
View reviewed changes
bin/install
else
echo "https://releases.hashicorp.com/${toolname}/${version}/${filename}"
fi
echo "https://releases.hashicorp.com/${toolname}/${version}/${filename}"
Copy link
Member

@smorimoto smorimoto Jul 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
echo "https://releases.hashicorp.com/${toolname}/${version}/${filename}"
echo "${releases_host}/${toolname}/${version}/${filename}"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smorimoto smorimoto smorimoto left review comments

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@azmelanar @smorimoto