Tweaks to storage functions for zarr 3 compatibility#61
Conversation
|
Thanks. Would you provide some context for these changes? Do they fix some issue or allow some new feature? Would you add tests that cover this? |
| for k in _iter_chunk_keys(zarray, only_initialized=True): | ||
| index = chunk_key_block_index_map[k] | ||
| coords = tuple([int(sk) for sk in k.split(dimension_separator)]) | ||
| coords = tuple([int(sk) for sk in k.split(dimension_separator)[1:]]) # Don't need the leading 'c/' |
There was a problem hiding this comment.
is it ever possible for this to skip data? can the dimension ever start with a coordinate instead of c/?
There was a problem hiding this comment.
Honestly I have no idea. I was hoping someone more familiar with the project could tell me. If it turns out it is then obviously I'll make this catch more cases.
|
@braingram Yes, sorry for springing this up out of nowhere. The fixes are for specific issues I've had trying to serialise a zarray as part of a more complex structure (saving a zarray on its own works just fine I believe). Specifically I need these changes to make this PR work. I'll probably need to make some more changes as I work through that, so I'll make sure this gets appropriate tests and a better description over the next few days as I get a chance. |
|
Thanks. I'll convert this back to draft for now until the other changes are ready. |
3 participants
No description provided.