Skip to content

fix astrocut downstream tests#1912

Merged
braingram merged 1 commit into
asdf-format:mainfrom
braingram:fix_astrocut
Apr 21, 2025
Merged

fix astrocut downstream tests#1912
braingram merged 1 commit into
asdf-format:mainfrom
braingram:fix_astrocut

Conversation

@braingram
Copy link
Copy Markdown
Contributor

@braingram braingram commented Apr 21, 2025

Description

astrocut moved their asdf tests in spacetelescope/astrocut#149

This PR updates the astrocut downstream tests here to use --pyargs which looks to be the expected way to run these tests based on:
https://github.com/spacetelescope/astrocut/blob/9c5aebecd806705e3942bd9204dd8be705b38059/tox.ini#L65
also rather than calling just the asdf tests (which breaks every time they rename/reorg the test files) this PR also just runs all astrocut tests.

Tasks

  • run pre-commit on your machine
  • run pytest on your machine
  • Does this PR add new features and / or change user-facing code / API? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
    • update relevant docstrings and / or docs/ page
    • for any new features, add unit tests
news fragment change types...
  • changes/<PR#>.feature.rst: new feature
  • changes/<PR#>.bugfix.rst: bug fix
  • changes/<PR#>.doc.rst: documentation change
  • changes/<PR#>.removal.rst: deprecation or removal of public API
  • changes/<PR#>.general.rst: infrastructure or miscellaneous change

@braingram braingram marked this pull request as ready for review April 21, 2025 14:08
@braingram braingram requested a review from a team as a code owner April 21, 2025 14:08
@braingram
Copy link
Copy Markdown
Contributor Author

astrocut downstream tests now passed. As this PR only changes that line will merge.

@braingram braingram merged commit 9149ab6 into asdf-format:main Apr 21, 2025
59 of 69 checks passed
@braingram braingram deleted the fix_astrocut branch April 21, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant