allow non-null post tree pre block padding#1918
Merged
Merged
Conversation
zacharyburnett
approved these changes
Apr 29, 2025
Member
zacharyburnett
left a comment
There was a problem hiding this comment.
as far as I can tell this looks good to me
might as well add a SorcerersTome class with all this reading of magic blocks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On main if padding bytes are found between the end of the tree and the beginning of the first block they must be all null.
asdf/asdf/_block/reader.py
Lines 172 to 173 in ad470c0
This doesn't agree with the standard:
This PR updates the block parsing to allow non-null bytes as long as they don't match the block magic. Since the block header does not contain a checksum of the header bytes it's not possible to detect invalid padding (that includes the block magic). See asdf-format/asdf-standard#460
Once this is merged and asdf-format/asdf-standard#456 are merged asdf-format/asdf-standard#441 can be closed.
Tasks
pre-commiton your machinepyteston your machineno-changelog-entry-needed)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see below for change types)docs/pagenews fragment change types...
changes/<PR#>.feature.rst: new featurechanges/<PR#>.bugfix.rst: bug fixchanges/<PR#>.doc.rst: documentation changechanges/<PR#>.removal.rst: deprecation or removal of public APIchanges/<PR#>.general.rst: infrastructure or miscellaneous change