Skip to content

add weldx downstream#1919

Merged
braingram merged 1 commit into
asdf-format:mainfrom
braingram:weldx_downstream
Apr 24, 2025
Merged

add weldx downstream#1919
braingram merged 1 commit into
asdf-format:mainfrom
braingram:weldx_downstream

Conversation

@braingram
Copy link
Copy Markdown
Contributor

@braingram braingram commented Apr 24, 2025

Description

Re-enables weldx downstream tests.

weldx tests are now passing: https://github.com/asdf-format/asdf/actions/runs/14647049842/job/41103793924?pr=1919

Closes #1870

Tasks

  • run pre-commit on your machine
  • run pytest on your machine
  • Does this PR add new features and / or change user-facing code / API? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
    • update relevant docstrings and / or docs/ page
    • for any new features, add unit tests
news fragment change types...
  • changes/<PR#>.feature.rst: new feature
  • changes/<PR#>.bugfix.rst: bug fix
  • changes/<PR#>.doc.rst: documentation change
  • changes/<PR#>.removal.rst: deprecation or removal of public API
  • changes/<PR#>.general.rst: infrastructure or miscellaneous change

@braingram braingram marked this pull request as ready for review April 24, 2025 16:50
@braingram braingram requested a review from a team as a code owner April 24, 2025 16:50
@braingram
Copy link
Copy Markdown
Contributor Author

Since this is a single line change to a github workflow that's passing I'm going to merge this.

@braingram braingram merged commit ad470c0 into asdf-format:main Apr 24, 2025
60 of 69 checks passed
@CagtayFabry
Copy link
Copy Markdown
Contributor

Thank you @braingram

Sorry about the delay

@braingram
Copy link
Copy Markdown
Contributor Author

Thank you @braingram

Sorry about the delay

No worries. Let me know if there's anything I can do to help with the transitions in API, schema, etc. We're going through a collection of docs updates and I haven't forgotten about #1895. Feel free to open issues, respond here or otherwise reach out if you have any thoughts on things we can improve.

@braingram braingram deleted the weldx_downstream branch April 24, 2025 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tracking weldx downstream updates

2 participants