Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion asdf/_core/_converters/ndarray.py
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,8 @@
if isinstance(node, list):
instance = NDArrayType(node, None, None, None, None, None, None)
ctx._blocks._set_array_storage(instance, "inline")
if not ctx._blocks._lazy_load:
return instance._make_array()

Check warning on line 147 in asdf/_core/_converters/ndarray.py

View check run for this annotation

Codecov / codecov/patch

asdf/_core/_converters/ndarray.py#L147

Added line #L147 was not covered by tests
return instance

if isinstance(node, dict):
Expand Down Expand Up @@ -185,7 +187,7 @@
ctx._blocks._set_array_storage(instance, "inline")

if not ctx._blocks._lazy_load:
instance._make_array()
return instance._make_array()
return instance

msg = "Invalid ndarray description."
Expand Down
16 changes: 16 additions & 0 deletions asdf/_tests/tags/core/tests/test_ndarray.py
Original file line number Diff line number Diff line change
Expand Up @@ -1105,3 +1105,19 @@ def test_shape_does_not_load_array(tmp_path):
assert af["arr"]._array is None
assert af["arr"].shape == (100,)
assert af["arr"]._array is None


@pytest.mark.parametrize(
"lazy_load, array_class",
(
(True, ndarray.NDArrayType),
(False, np.ndarray),
),
)
@pytest.mark.parametrize("lazy_tree", [True, False])
def test_lazy_load_array_class(tmp_path, lazy_load, lazy_tree, array_class):
file_path = tmp_path / "test.asdf"
asdf.AsdfFile({"arr": np.arange(100)}).write_to(file_path)

with asdf.open(file_path, lazy_load=lazy_load, lazy_tree=lazy_tree) as af:
assert type(af["arr"]) is array_class
1 change: 1 addition & 0 deletions changes/1929.bugfix.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
When ``lazy_load=False`` use ``ndarray`` instances for arrays (instead of ``NDArrayType``).
Loading