Skip to content

warn when bundled pytest plugin runs#1959

Merged
braingram merged 1 commit into
asdf-format:mainfrom
braingram:warn_for_pytest_plugin
Aug 25, 2025
Merged

warn when bundled pytest plugin runs#1959
braingram merged 1 commit into
asdf-format:mainfrom
braingram:warn_for_pytest_plugin

Conversation

@braingram

@braingram braingram commented Aug 19, 2025

Copy link
Copy Markdown
Contributor

Description

With the release of https://pypi.org/project/pytest-asdf-plugin/ and updates to our downstream to use the new plugin we can start warning when the bundled plugin is used.

This PR issues a warning when the bundled plugin runs a test.

Requires:

Tasks

  • run pre-commit on your machine
  • run pytest on your machine
  • Does this PR add new features and / or change user-facing code / API? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
    • update relevant docstrings and / or docs/ page
    • for any new features, add unit tests
news fragment change types...
  • changes/<PR#>.feature.rst: new feature
  • changes/<PR#>.bugfix.rst: bug fix
  • changes/<PR#>.doc.rst: documentation change
  • changes/<PR#>.removal.rst: deprecation or removal of public API
  • changes/<PR#>.general.rst: infrastructure or miscellaneous change

@braingram braingram force-pushed the warn_for_pytest_plugin branch from 0d98b4d to 137cd58 Compare August 19, 2025 12:31
@braingram braingram marked this pull request as ready for review August 21, 2025 14:38
@braingram braingram requested a review from a team as a code owner August 21, 2025 14:38
@braingram

Copy link
Copy Markdown
Contributor Author

I'm opening this for review. We will need the rad changes before we release but I don't seen any devdeps testing in rad that uses asdf so we're safe to merge this prior to the rad changes.

@zacharyburnett zacharyburnett left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM

@braingram braingram force-pushed the warn_for_pytest_plugin branch from 137cd58 to c5a7584 Compare August 25, 2025 15:32
@braingram braingram merged commit 6eec5ba into asdf-format:main Aug 25, 2025
53 checks passed
@braingram braingram deleted the warn_for_pytest_plugin branch August 25, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants