Add typing-extensions dependency#2040
Open
sydduckworth wants to merge 6 commits into
Open
Conversation
sydduckworth
added
dependencies
zacharyburnett
approved these changes
May 7, 2026
Member
zacharyburnett
left a comment
zacharyburnett
left a comment
There was a problem hiding this comment.
LGTM, how does the deprecated decorator look to users? It's https://peps.python.org/pep-0702/ right?
Member
|
nvm found it https://docs.python.org/3.13/library/warnings.html#warnings.deprecated, looks neat! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
typing-extensionsas a dependencyReaderandWriterprotocols inasdf.typingand replaced them with the backports fromtyping_extensionstyping-extensionsbackports various typing features so that they're available in older Python versions.In addition to letting us remove the custom protocols as described above, it also gives access to the
deprecateddecorator which was added towarningsin Python 3.14 and will be very useful as we start to deprecate parts of the API.Worth noting that
typing-extensionsis already an indirect dependency of several optional dependencies.