fix add_history_entry validation to ignore custom schema#2044
Open
braingram wants to merge 4 commits into
Open
fix add_history_entry validation to ignore custom schema#2044braingram wants to merge 4 commits into
braingram wants to merge 4 commits into
Conversation
Contributor
Author
|
From offline conversation with @Cadair this fixes the CI failures they are seeing with 3.5.0. @sydduckworth any objection if we put this in a patch release (3.5.1)? Should we include the other changes on main? |
Cadair
reviewed
May 7, 2026
Contributor
|
I'm fine with a patch release! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fixes a bug introduced by #2029 where if a user:
The call to
add_history_entrycan fail due to the validation:This PR fixes the issue by providing a blank schema to
validate(which will be used instead of the custom schema). The tagged entry will still be validated.Hopefully we can get some confirmation from dkist that this fixes the issues they had with asdf 5.3.0. Unfortunately this was only revealed in tests for https://bitbucket.org/dkistdc/dkist-inventory/src which we did not have in our downstream. This PR also adds that to our downstream.
Tasks
prekon your machinepyteston your machineno-changelog-entry-needed)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see below for change types)docs/pagenews fragment change types...
changes/<PR#>.feature.rst: new featurechanges/<PR#>.bugfix.rst: bug fixchanges/<PR#>.doc.rst: documentation changechanges/<PR#>.removal.rst: deprecation or removal of public APIchanges/<PR#>.general.rst: infrastructure or miscellaneous change