-
Notifications
You must be signed in to change notification settings - Fork 73
fix: use absolute path in latest-stable
callback when calling list-all
#144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@navinpeiris can you explain how this fixes #143? @Eiji7 can you test this? |
@Stratus3D Not sure if remember correctly, but there may be problems if
That's why initially I used the btw. Sorry for asking it many times, but any idea if #142 PR is going to be accepted? |
bin/latest-stable
Outdated
# calling a script to list all elixir releases | ||
# reject releases before 1.0.0 (starting with 0) | ||
# reject main and master branches | ||
# reject releases with otp version | ||
# reject release candidates | ||
# reject empty line | ||
# finally take last one | ||
ASDF_ELIXIR_LATEST_VERSION=$(./list-all | tr " " "\n" | grep -Ev "^0|^main|^master|otp|rc|^$" | tail -n 1) | ||
ASDF_ELIXIR_LATEST_VERSION=$($SCRIPT_DIR/list-all | tr " " "\n" | grep -Ev "^0|^main|^master|otp|rc|^$" | tail -n 1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think $SCRIPT_DIR
here should be wrapped in quotes, otherwise this looks good to me.
2062f65
to
d129ab4
Compare
Sorry, should have done that when submitting the PR! The call to This would then cause
I've wrapped |
latest-stable
callback when calling list-all
Fixes #143