fix: avoid interpolating args into bash -c in execute package#2252
Open
RobertoLuzanilla wants to merge 3 commits intoasdf-vm:masterfrom
Open
fix: avoid interpolating args into bash -c in execute package#2252RobertoLuzanilla wants to merge 3 commits intoasdf-vm:masterfrom
RobertoLuzanilla wants to merge 3 commits intoasdf-vm:masterfrom
Conversation
RobertoLuzanilla
changed the title
RobertoLuzanilla
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevents shell command injection by avoiding interpolation of arguments into the
bash -ccommand string.Passes arguments via
$0/$@instead of formatting them into the shell command.Adds a regression test covering the reported payload pattern.
Security note: this PR addresses the primary reported issue (CWE-78 via user-controlled plugin URL arguments). Other findings (e.g.,
$SHELLandASDF_DATA_DIRcases) are intentionally out of scope and can be handled separately if desired.