[win] Fix opening multiple files with native dialog (fix aseprite/aseprite#5698) - #190
Merged
Conversation
…prite#5698) There were two issues: 1. Stop reading "childRead" handle too early. We have to keep reading the child process output until we receive an error from ReadFile(), we don't need an extra m_closingRead flag. 2. Discarding some extra read bytes after the first '\r\n' is found. We have to keep reading and building each line even when the buffer is full.
aseprite-bot
left a comment
aseprite-bot
left a comment
Collaborator
There was a problem hiding this comment.
clang-tidy made some suggestions
| @@ -21,7 +21,6 @@ | |||
| #include <shobjidl.h> | |||
Collaborator
There was a problem hiding this comment.
warning: 'shobjidl.h' file not found [clang-diagnostic-error]
#include <shobjidl.h>
^
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes aseprite/aseprite#5698