Testing clang-tidy (?) - #201
Closed
dacap wants to merge 1 commit into
Closed
Conversation
Collaborator
|
clang-tidy review says "All clean, LGTM! 👍" |
dacap
force-pushed
the
test-clang-tidy
branch
from
September 3, 2026 19:39
dfc6538 to
fd67855
Compare
aseprite-bot
reviewed
Sep 3, 2026
aseprite-bot
left a comment
aseprite-bot
left a comment
Collaborator
There was a problem hiding this comment.
clang-tidy made some suggestions
|
|
||
| // crash? | ||
| char* ptr = nullptr; | ||
| *ptr = 1; |
Collaborator
There was a problem hiding this comment.
warning: Dereference of null pointer (loaded from variable 'ptr') [clang-analyzer-core.NullDereference]
*ptr = 1;
^Additional context
examples/listscreens.cpp:41: 'ptr' initialized to a null pointer value
char* ptr = nullptr;
^examples/listscreens.cpp:42: Dereference of null pointer (loaded from variable 'ptr')
*ptr = 1;
^
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing, close