-
Notifications
You must be signed in to change notification settings - Fork 43
Replace quotes in the PR template with html comments #254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,52 +1,18 @@ | ||
## Purpose | ||
> Describe the problems, issues, or needs driving this feature/fix and include links to related issues in the following format: Resolves issue1, issue2, etc. | ||
### Purpose | ||
<!-- Describe the problem, feature, improvement or the change introduces by the PR briefly. Add screenshots/GIFs if UI/UX changes are introduced. --> | ||
|
||
## Goals | ||
> Describe the solutions that this feature/fix will introduce to resolve the problems described above | ||
### Related Issues | ||
- | ||
|
||
## Approach | ||
> Describe how you are implementing the solutions. Include an animated GIF or screenshot if the change affects the UI (email [email protected] to review all UI text). Include a link to a Markdown file or Google doc if the feature write-up is too long to paste here. | ||
### Related PRs | ||
- | ||
|
||
## User stories | ||
> Summary of user stories addressed by this change> | ||
### Checklist | ||
- [ ] Manual test round performed and verified. | ||
- [ ] UX/UI review done on the final implementation. | ||
- [ ] Documentation provided. (Add links if there are any) | ||
- [ ] Unit tests provided. (Add links if there are any) | ||
|
||
## Release note | ||
> Brief description of the new feature or bug fix as it will appear in the release notes | ||
|
||
## Documentation | ||
> Link(s) to product documentation that addresses the changes of this PR. If no doc impact, enter “N/A” plus brief explanation of why there’s no doc impact | ||
|
||
## Training | ||
> Link to the PR for changes to the training content in https://github.com/wso2/WSO2-Training, if applicable | ||
|
||
## Certification | ||
> Type “Sent” when you have provided new/updated certification questions, plus four answers for each question (correct answer highlighted in bold), based on this change. Certification questions/answers should be sent to [email protected] and NOT pasted in this PR. If there is no impact on certification exams, type “N/A” and explain why. | ||
|
||
## Marketing | ||
> Link to drafts of marketing content that will describe and promote this feature, including product page changes, technical articles, blog posts, videos, etc., if applicable | ||
|
||
## Automation tests | ||
- Unit tests | ||
> Code coverage information | ||
- Integration tests | ||
> Details about the test cases and coverage | ||
|
||
## Security checks | ||
- Followed secure coding standards in http://wso2.com/technical-reports/wso2-secure-engineering-guidelines? yes/no | ||
- Ran FindSecurityBugs plugin and verified report? yes/no | ||
- Confirmed that this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets? yes/no | ||
|
||
## Samples | ||
> Provide high-level details about the samples related to this feature | ||
|
||
## Related PRs | ||
> List any other related PRs | ||
|
||
## Migrations (if applicable) | ||
> Describe migration steps and platforms on which migration has been tested | ||
|
||
## Test environment | ||
> List all JDK versions, operating systems, databases, and browser/versions on which this feature/fix was tested | ||
|
||
## Learning | ||
> Describe the research phase and any blog posts, patterns, libraries, or add-ons you used to solve the problem. | ||
### Security checks | ||
- [ ] Followed secure coding standards in http://wso2.com/technical-reports/wso2-secure-engineering-guidelines? | ||
- [ ] Confirmed that this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets? |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.