Skip to content

Update@asgardeo/auth-spa to v3.2.0 #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 4, 2025
Merged

Update@asgardeo/auth-spa to v3.2.0 #293

merged 2 commits into from
Apr 4, 2025

Conversation

brionmario
Copy link
Member

@brionmario brionmario commented Apr 3, 2025 •
edited
Loading

Purpose

ATM, when using TypeScript, we can't pass the storage option as strings. We need to use the Storage enum or cast the string. This is not good DX.

Related issues

Security checks

Samples

N/A

Related PRs

pavinduLakshan
pavinduLakshan previously approved these changes Apr 3, 2025
View reviewed changes
@brionmario brionmario merged commit cab9541 into asgardeo:main Apr 4, 2025
1 check passed
@brionmario brionmario mentioned this pull request Apr 4, 2025
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavinduLakshan pavinduLakshan pavinduLakshan approved these changes

@NipuniBhagya NipuniBhagya Awaiting requested review from NipuniBhagya NipuniBhagya is a code owner

@inthirakumaaran inthirakumaaran Awaiting requested review from inthirakumaaran inthirakumaaran is a code owner

@jeradrutnam jeradrutnam Awaiting requested review from jeradrutnam jeradrutnam is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't use a string literal to define the storage option when used with TypeScript
2 participants
@brionmario @pavinduLakshan