fix: fix password field type in SignUp in Thunder ⚡ #245
Merged
brionmario merged 2 commits intoasgardeo:mainfrom Nov 14, 2025
Merged
fix: fix password field type in SignUp in Thunder ⚡ #245brionmario merged 2 commits intoasgardeo:mainfrom
SignUp in Thunder ⚡ #245brionmario merged 2 commits intoasgardeo:mainfrom
Conversation
4e8521b to
d2ac85b
Compare
🦋 Changeset detectedThe changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. |
DonOmalVindula
approved these changes
Nov 14, 2025
SignUp in AsgardeoV2 AKA Thunder ⚡ SignUp in Thunder ⚡
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request addresses a bug with the password field type in the sign-up component and improves the user interface by making input labels more readable. The most significant changes include fixing the password field type handling and updating label formatting to better support camelCase field names.
Bug fix and input handling:
password) is used when generating input variants, labels, and placeholders in theconvertSimpleInputToComponentfunction intransformer.ts, preventing potential UI or validation issues. [1] [2]User interface improvements:
getInputLabelfunction intransformer.tsto convert camelCase field names to sentence case (e.g.,firstNamebecomesFirst name), improving label readability for end users.Related Issues
asgardeo/thunderruntime #212@asgardeo/react&@asgardeo/nextjs#81Related PRs
Checklist
Security checks