Skip to content

Conversation

@NilukaSripalim
Copy link
Contributor

Purpose

This PR adds the tests/e2e folder to the existing pnpm workspace so it can reuse shared tools such as linters, Prettier, and other common dependencies. This helps keep tooling consistent across the project and avoids managing duplicate configurations.


⚠️ Breaking Changes

🔧 Summary of Breaking Changes

Describe what is changing

💥 Impact

What will break? Who is affected?

🔄 Migration Guide

How should users update their code/configuration to adapt to the breaking changes? Include examples if helpful


-->

Approach

Related Issues

  • N/A

Related PRs

  • N/A

Checklist

  • Followed the contribution guidelines.
  • Manual test round performed and verified.
  • Documentation provided. (Add links if there are any)
  • Tests provided. (Add links if there are any)
    • Unit Tests
    • Integration Tests
  • Breaking changes. (Fill if applicable)
    • Breaking changes section filled.
    • breaking change label added.

Security checks

  • Followed secure coding standards in WSO2 Secure Coding Guidelines
  • Confirmed that this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR integrates the tests/e2e folder into the pnpm workspace to share tooling (linters, Prettier, etc.) across the project. The changes remove local tool dependencies, delete the standalone ESLint config and package-lock.json, and update the GitHub Actions workflow to use pnpm instead of npm for E2E test execution.

Changes:

  • Added tests/e2e to the pnpm workspace and updated dependencies to use shared tooling
  • Removed redundant configuration files (eslint.config.mjs, package-lock.json) from the e2e directory
  • Updated GitHub Actions workflow to use pnpm for installing and running E2E tests

Reviewed changes

Copilot reviewed 4 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/e2e/package.json Removed TypeScript ESLint plugins, downgraded ESLint to 8.57.1, added nx configuration for task orchestration
tests/e2e/package-lock.json Deleted entire package-lock.json (2726 lines) as e2e is now part of pnpm workspace
tests/e2e/eslint.config.mjs Removed standalone ESLint configuration file (52 lines)
frontend/pnpm-workspace.yaml Added ../tests/e2e to workspace packages
frontend/pnpm-lock.yaml Added e2e dependencies to the shared lockfile
.github/workflows/pr-builder.yml Updated E2E job to use pnpm instead of npm, improved logging and error handling
Files not reviewed (2)
  • frontend/pnpm-lock.yaml: Language not supported
  • tests/e2e/package-lock.json: Language not supported

@codecov
Copy link

codecov bot commented Jan 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.20%. Comparing base (46e68db) to head (d574f4c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1086      +/-   ##
==========================================
- Coverage   87.22%   87.20%   -0.03%     
==========================================
  Files         535      535              
  Lines       36114    36114              
  Branches     1611     1611              
==========================================
- Hits        31501    31492       -9     
- Misses       2978     2985       +7     
- Partials     1635     1637       +2     
Flag Coverage Δ
backend-integration-postgres 54.96% <ø> (ø)
backend-integration-sqlite 54.93% <ø> (ø)
backend-unit 79.02% <ø> (-0.04%) ⬇️
frontend-apps-develop-unit 80.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@NilukaSripalim NilukaSripalim added the skip-changelog Skip generating changelog for a particular PR label Jan 15, 2026
Copilot AI review requested due to automatic review settings January 16, 2026 07:03
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 6 changed files in this pull request and generated 2 comments.

Files not reviewed (2)
  • frontend/pnpm-lock.yaml: Language not supported
  • tests/e2e/package-lock.json: Language not supported

"prettier": "3.4.2",
"typescript": "5.7.3"
"prettier": "3.6.2",
"typescript": "5.9.3"
Copy link

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The TypeScript version should be aligned with the workspace catalog. According to the pnpm-lock.yaml, the catalog specifies TypeScript 5.9.3, so this should use 'catalog:' to maintain consistency across the workspace.

Suggested change
"typescript": "5.9.3"
"typescript": "catalog:typescript"

Copilot uses AI. Check for mistakes.
TEST_USER_USERNAME: ${{ secrets.PLAYWRIGHT_TEST_USER_USERNAME || vars.PLAYWRIGHT_TEST_USER_USERNAME || 'testuser' }}
TEST_USER_PASSWORD: ${{ secrets.PLAYWRIGHT_TEST_USER_PASSWORD || 'admin' }}
PLAYWRIGHT_WORKERS: ${{ vars.PLAYWRIGHT_WORKERS || 1 }}
PLAYWRIGHT_WORKERS: ${{ vars.PLAYWRIGHT_WORKERS || '1' }}
Copy link

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The environment variable is being set as a string '1' instead of numeric 1. While this may work, Playwright typically expects numeric values for the workers configuration. Consider removing the quotes or ensuring Playwright handles string-to-number conversion correctly.

Suggested change
PLAYWRIGHT_WORKERS: ${{ vars.PLAYWRIGHT_WORKERS || '1' }}
PLAYWRIGHT_WORKERS: ${{ vars.PLAYWRIGHT_WORKERS || 1 }}

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog Skip generating changelog for a particular PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant