-
Notifications
You must be signed in to change notification settings - Fork 265
Generate separate key pair for digital signatures #1131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
2aaee06 to
3e7799c
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1131 +/- ##
==========================================
+ Coverage 89.78% 89.85% +0.07%
==========================================
Files 586 586
Lines 38880 38875 -5
Branches 1967 1967
==========================================
+ Hits 34907 34931 +24
+ Misses 2239 2230 -9
+ Partials 1734 1714 -20
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3e7799c to
4b31bb2
Compare
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
6ce6c33 to
5a010f3
Compare
5a010f3 to
0f9dbf1
Compare
Purpose
This PR addresses the security best practice of using separate key pairs for different purposes (TLS vs. digital signatures). Previously, the same key pair (
server.certandserver.key) was used for both TLS connections and JWT/token signing operations, which violates security best practices and increases risk if one key is compromised.Changes:
server.cert/server.keysigning.cert/signing.key(new)Certificate Generation Strategy:
Approach
Build Scripts (
build.sh/build.ps1)ensure_certificates()/Ensure-Certificates()functions to accept acert_name_prefixparameterCertificate Generation Locations:
Configuration (
default.json)"crypto": { "keys": [ { "id": "default-key", - "cert_file": "repository/resources/security/server.cert", - "key_file": "repository/resources/security/server.key" + "cert_file": "repository/resources/security/signing.cert", + "key_file": "repository/resources/security/signing.key" } ] }Related Issues
Related PRs
Checklist
breaking changelabel added.Security checks
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.