Update database credentials to use 'dbuser' and 'dbpassword' across configurations#2502
Conversation
|
Warning Rate limit exceeded
To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (12)
📝 WalkthroughWalkthroughDefault PostgreSQL database credentials are updated from Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Suggested labels
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 55 minutes and 23 seconds.Comment |
brionmario
added
the
skip-changelog
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@install/openchoreo/helm/README.md`:
- Around line 372-373: The README contains a username mismatch: the SQL examples
create/grant for "dbuser" while the environment export still sets
DB_USER="thunder"; update the environment export(s) to use DB_USER="dbuser" (or
alternatively change the SQL to use "thunder") so the exported DB_USER variable
and the SQL commands (CREATE DATABASE ... OWNER and GRANT ... TO) match; ensure
you update both occurrences mentioned so the install steps use the same username
consistently.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 2345cf21-1b1a-4ac6-afc0-dfeb7550357b
📒 Files selected for processing (12)
.github/actions/run-integration-tests/action.yml.github/workflows/postgres-tests.yml.github/workflows/pr-builder.yml.github/workflows/release-builder.ymlREADME.mdinstall/helm/README.mdinstall/helm/values.yamlinstall/local-development/docker-compose.ymlinstall/local-development/redis/docker-compose.ymlinstall/openchoreo/helm/README.mdtests/integration/resources/scripts/setup-test-config.ps1tests/integration/resources/scripts/setup-test-config.sh
brionmario
force-pushed
the
refactor-thunder-rebrand
branch
from
92bc2d2 to
ab0b9dd
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2502 +/- ##
==========================================
- Coverage 87.36% 87.35% -0.02%
==========================================
Files 890 890
Lines 62738 62738
==========================================
- Hits 54810 54803 -7
- Misses 5941 5947 +6
- Partials 1987 1988 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2 participants
Purpose
This pull request standardizes the database and Redis usernames and passwords used throughout the project. The credentials have been changed from
asgthunder/asgthundertodbuser/dbpasswordin configuration files, scripts, documentation, and CI/CD workflows to ensure consistency and simplify setup across development, testing, and deployment environments.Approach
Credential Standardization
asgthunder/asgthundertodbuser/dbpasswordin configuration files such asinstall/helm/values.yaml,install/local-development/docker-compose.yml, andinstall/local-development/redis/docker-compose.yml. [1] [2] [3] [4] [5] [6]CI/CD Workflow Updates
.github/workflows/postgres-tests.yml,.github/workflows/pr-builder.yml,.github/workflows/release-builder.yml,.github/actions/run-integration-tests/action.yml). [1] [2] [3] [4]Documentation and Example Configuration
README.md,install/helm/README.md, andinstall/openchoreo/helm/README.mdto reflect the new default credentials. [1] [2] [3] [4] [5]Test Setup Scripts
setup-test-config.ps1,setup-test-config.sh) to use the new credentials for all database types. [1] [2] [3] [4] [5] [6]This change ensures that all environments and documentation are aligned with the new default credentials, reducing confusion and potential misconfiguration.
Related Issues
Related PRs
Checklist
breaking changelabel added.Security checks