Add initial user API #26
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| userService := userProvider.GetUserService() | ||
| user, err := userService.GetUser(id) | ||
| if err != nil { | ||
| http.Error(w, "Failed get user", http.StatusInternalServerError) |
There was a problem hiding this comment.
We should handle client errors here right? Otherwise there will be a 500 for non existing users as well.
Same with put and delete
| userService := userProvider.GetUserService() | ||
| err := userService.DeleteUser(id) | ||
| if err != nil { | ||
| http.Error(w, "Failed delete user", http.StatusInternalServerError) |
There was a problem hiding this comment.
Maybe should return 200 for user non existing case
| // @Failure 500 {string} "Internal Server Error: An unexpected error occurred while processing the request." | ||
| // @Router /users [post] | ||
| func (ah *UserHandler) HandleUserPostRequest(w http.ResponseWriter, r *http.Request) { | ||
|
|
There was a problem hiding this comment.
As discussed during last week's review, shall we remove empty line after the func definition?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request introduces a new user management feature to the backend system. It includes database schema updates for both PostgreSQL and SQLite, a new
UserServicewith REST API endpoints, and supporting models, handlers, and data storage logic. Below are the most important changes grouped by theme:Database Schema Updates
USERtable to both PostgreSQL (postgress.sql) and SQLite (sqlite.sql) schemas to store user details such asUSER_ID,ORG_ID,TYPE, andATTRIBUTES. The table includes timestamps forCREATED_ATandUPDATED_AT. [1] [2]USERtable in both PostgreSQL and SQLite scripts. [1] [2]Service Layer Implementation
UserServiceinuserservice.goto handle user-related operations, including creating, retrieving, updating, and deleting users. The service is registered in theServiceManager. [1] [2]REST API for User Management
UserHandlerinuserhandler.goto define REST API endpoints (POST,GET,PUT,DELETE) for user management. Each endpoint is mapped to a corresponding service method.Supporting Models and Providers
Usermodel inuser.goto represent user data, includingId,OrgId,Type, andAttributes.UserProviderinuserprovider.goto abstract the creation and retrieval of theUserServiceinstance.Data Storage Layer
constants.gounder thestorepackage. These queries are used by theUserServiceto interact with the database.