fix: call manage_relationships in single hard destroy path (#2596)

The single hard destroy path in `destroy.ex` never called
`manage_relationships`, causing any `manage_relationship` changes
declared on hard destroy actions to be silently ignored. The bulk
destroy, soft destroy, create, and update paths all properly called
`manage_relationships`.

Adds `manage_relationships/4` to `Ash.Actions.Destroy` following the
same pattern used in `Ash.Actions.Update`, and pipes the data layer
result through it before the notification/select pipeline.

Also adds comprehensive tests for manage_relationship on destroy
actions: single hard destroy, single soft destroy, bulk hard destroy,
and bulk soft destroy.

Closes ash-project/ash_postgres#702

Author: barnabasJ

lib/ash/actions/destroy/destroy.ex

@@ -242,11 +242,15 @@ defmodule Ash.Actions.Destroy do
                   end
                 end
               end
+              |> manage_relationships(domain, changeset,
+                actor: opts[:actor],
+                authorize?: opts[:authorize?]
+              )
               |> then(fn result ->
                 case result do
-                  {:ok, destroyed} ->
+                  {:ok, destroyed, %{notifications: manage_notifications}} ->
                     if opts[:return_destroyed?] do
-                      {:ok, destroyed, %{notifications: []}}
+                      {:ok, destroyed, %{notifications: manage_notifications}}
                       |> Helpers.notify(changeset, opts)
                       |> Helpers.select(changeset)
                       |> Helpers.restrict_field_access(changeset)
@@ -257,7 +261,7 @@ defmodule Ash.Actions.Destroy do
                           select: changeset.action_select
                         })
 
-                      {:ok, destroyed, %{notifications: []}}
+                      {:ok, destroyed, %{notifications: manage_notifications}}
                       |> Helpers.notify(changeset, opts)
                     end
 
@@ -304,6 +308,37 @@ defmodule Ash.Actions.Destroy do
     end
   end
 
+  defp manage_relationships(
+         {:ok, destroyed, %{notifications: notifications}},
+         domain,
+         changeset,
+         engine_opts
+       ) do
+    case manage_relationships({:ok, destroyed}, domain, changeset, engine_opts) do
+      {:ok, destroyed, info} ->
+        {:ok, destroyed, Map.update(info, :notifications, notifications, &(&1 ++ notifications))}
+
+      other ->
+        other
+    end
+  end
+
+  defp manage_relationships({:ok, destroyed}, domain, changeset, engine_opts) do
+    with {:ok, loaded} <-
+           Ash.Actions.ManagedRelationships.load(domain, destroyed, changeset, engine_opts),
+         {:ok, with_relationships, new_notifications} <-
+           Ash.Actions.ManagedRelationships.manage_relationships(
+             loaded,
+             changeset,
+             engine_opts[:actor],
+             engine_opts
+           ) do
+      {:ok, with_relationships, %{notifications: new_notifications}}
+    end
+  end
+
+  defp manage_relationships(other, _, _, _), do: other
+
   defp set_tenant(changeset) do
     changeset =
       case changeset.data do

lib/ash/error/unknown/invalid_casted_value.ex

@@ -1,3 +1,7 @@
+# SPDX-FileCopyrightText: 2019 ash contributors <https://github.com/ash-project/ash/graphs/contributors>
+#
+# SPDX-License-Identifier: MIT
+
 defmodule Ash.Error.Unknown.InvalidCastedValue do
   @moduledoc "Used when a value fails to dump to its native (storage) format"
 

lib/ash/error/unknown/invalid_stored_value.ex

@@ -1,3 +1,7 @@
+# SPDX-FileCopyrightText: 2019 ash contributors <https://github.com/ash-project/ash/graphs/contributors>
+#
+# SPDX-License-Identifier: MIT
+
 defmodule Ash.Error.Unknown.InvalidStoredValue do
   @moduledoc "Used when a stored value fails to be cast from the data layer"