add missing types to Ash.load typespec#2167
Merged
zachdaniel merged 3 commits intomainfrom Jun 27, 2025
Merged
Conversation
zachdaniel
previously approved these changes
Jun 26, 2025
zachdaniel
reviewed
Jun 26, 2025
| """ | ||
| @spec load( | ||
| record_or_records :: Ash.Resource.record() | [Ash.Resource.record()] | nil, | ||
| record_or_records :: |
Contributor
There was a problem hiding this comment.
Looks good, can we also do this for load!?
Contributor
Author
There was a problem hiding this comment.
Sorry, my bad. I also reused some of the already defined types in the process.
barnabasJ
force-pushed
the
fix/ash-load-spec
branch
from
481f013 to
b96cbca
Compare
zachdaniel
approved these changes
Jun 27, 2025
Contributor
|
🚀 Thank you for your contribution! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributor checklist
Leave anything that you believe does not apply unchecked.