Skip to content

feat: Add array modifier to ash.gen.resource#2228

Merged
zachdaniel merged 2 commits intoash-project:mainfrom
ken-kost:enhancement-add-array-modifier
Jul 25, 2025
Merged

feat: Add array modifier to ash.gen.resource#2228
zachdaniel merged 2 commits intoash-project:mainfrom
ken-kost:enhancement-add-array-modifier

Conversation

@ken-kost
Copy link
Copy Markdown
Contributor

@ken-kost ken-kost commented Jul 25, 2025

#2227

Contributor checklist

Leave anything that you believe does not apply unchecked.

  • I accept the AI Policy, or AI was not used in the creation of this PR.
  • Bug fixes include regression tests
  • Chores
  • Documentation changes
  • Features include unit/acceptance tests
  • Refactoring
  • Update dependencies

@ken-kost ken-kost changed the title Enhancement: Add array modifier feat: Add array modifier to ash.gen.resource Jul 25, 2025
@chazwatkins
Copy link
Copy Markdown
Contributor

@ken-kost lol, you beat me to it. Was working on a PR too. We should probably callout which issues we're going to tackle. :)

What do you think about doing something like array[string] instead of list_string?

I was thinking of doing something like

defp resolve_type(type <> "[" <> subtype <> "]") do
  {resolve_type(type), resolve_type(subtype)}
end

@ken-kost
Copy link
Copy Markdown
Contributor Author

@ken-kost lol, you beat me to it. Was working on a PR too. We should probably callout which issues we're going to tackle. :)

What do you think about doing something like array[string] instead of list_string?

I was thinking of doing something like

defp resolve_type(type <> "[" <> subtype <> "]") do
  {resolve_type(type), resolve_type(subtype)}
end

list_string is just the name of attribute. But yeah, your sounds better. 👍

@zachdaniel zachdaniel merged commit 02147e0 into ash-project:main Jul 25, 2025
43 checks passed
@zachdaniel
Copy link
Copy Markdown
Contributor

🚀 Thank you for your contribution! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants